From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1951576AbdDYQXf (ORCPT ); Tue, 25 Apr 2017 12:23:35 -0400 Received: from mail.skyhub.de ([5.9.137.197]:53706 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1951496AbdDYQX2 (ORCPT ); Tue, 25 Apr 2017 12:23:28 -0400 Date: Tue, 25 Apr 2017 18:23:17 +0200 From: Borislav Petkov To: Denys Vlasenko Cc: Ingo Molnar , Andy Lutomirski , Brian Gerst , Peter Zijlstra , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86, msr: Document AMD "tweak MSRs", use MSR_FnnH_NAME scheme for them Message-ID: <20170425162317.pfy6amlgnj2a6xgd@pd.tnic> References: <20170425152705.13991-1-dvlasenk@redhat.com> <20170425160659.o5h5hb27ovwlwlei@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 25, 2017 at 06:15:23PM +0200, Denys Vlasenko wrote: > On 04/25/2017 06:06 PM, Borislav Petkov wrote: > > Pls no. Not every MSR for every family. Only the 4 which are actually > > being used. We can't hold in here the full 32-bit MSR space. > > The replacement of four define names is not the purpose > of the proposed patch. > > The patch was prompted by the realization that these particular MSRs > are so badly and inconsistently documented that it takes many hours > of work and requires reading of literally a dozen PDFs to figure out > what are their names, which CPUs have them, and what bits are known. They're all documented in the respective BKDGs or revision guides. > Anyone who looks at only one document won't see the full picture. And what is the big picture? To me it is just a bunch of MSRs. What's so special about them? > Patch does not document bits, but at least documents all MSR names > and explains why documentation is so sparse. No, we don't document MSRs in the kernel - we collect all the MSRs the kernel uses in msr-index.h. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.