From: Jamie Iles <jamie.iles@oracle.com>
To: Oleg Nesterov <oleg@redhat.com>, linux-kernel@vger.kernel.org
Subject: SIGNAL_UNKILLABLE and init again
Date: Tue, 25 Apr 2017 18:39:28 +0100 [thread overview]
Message-ID: <20170425173928.gaubfmxxbbvglnio@cedar> (raw)
Hi Oleg,
I'm back looking at SIGNAL_UNKILLABLE and debugging child reapers again,
and the current issue is when running code in the target process,
SIGTRAP firing and that causing SIGNAL_UNKILLABLE protection to be
removed in force_sig_info():
if (action->sa.sa_handler == SIG_DFL)
t->signal->flags &= ~SIGNAL_UNKILLABLE;
Would relaxing that if the task is being traced with something like
diff --git i/kernel/signal.c w/kernel/signal.c
index 7e59ebc2c25e..f701f1889895 100644
--- i/kernel/signal.c
+++ w/kernel/signal.c
@@ -1185,7 +1185,7 @@ force_sig_info(int sig, struct siginfo *info, struct task_struct *t)
recalc_sigpending_and_wake(t);
}
}
- if (action->sa.sa_handler == SIG_DFL)
+ if (action->sa.sa_handler == SIG_DFL && !t->ptrace)
t->signal->flags &= ~SIGNAL_UNKILLABLE;
ret = specific_send_sig_info(sig, info, t);
spin_unlock_irqrestore(&t->sighand->siglock, flags);
make any sense? It does address the issue that I'm seeing, but are
there any downsides to doing so?
Thanks,
Jamie
next reply other threads:[~2017-04-25 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 17:39 Jamie Iles [this message]
2017-04-26 15:18 ` Oleg Nesterov
2017-04-27 12:16 ` Jamie Iles
2017-08-14 9:31 ` Jamie Iles
2017-08-14 16:24 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425173928.gaubfmxxbbvglnio@cedar \
--to=jamie.iles@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®