From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Alan Cox <alan@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1 linux-next] staging: media: atomisp: kmap() can't fail
Date: Tue, 25 Apr 2017 20:35:18 +0200 [thread overview]
Message-ID: <20170425183518.GB8827@kroah.com> (raw)
In-Reply-To: <20170425181019.1655-1-fabf@skynet.be>
On Tue, Apr 25, 2017 at 08:10:19PM +0200, Fabian Frederick wrote:
> Remove NULL test on kmap()
That says _what_ you did, which is obvious if you read the patch. You
need to say _why_ you are doing what you are doing in this patch in the
changelog description.
thanks,
greg k-h
prev parent reply other threads:[~2017-04-25 18:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 18:10 Fabian Frederick
2017-04-25 18:35 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425183518.GB8827@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®