mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ilia Sergachev  <BM-2cVwRgNYPK72fLRfbWfkkmYLu7qHhYpwtr@bitmessage.ch>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ks7010: fix few checkpatch warnings in ks_wlan_net.c
Date: Tue, 25 Apr 2017 21:10:19 +0200	[thread overview]
Message-ID: <20170425191019.GA27234@kroah.com> (raw)
In-Reply-To: <20170425190248.6041-1-BM-2cVwRgNYPK72fLRfbWfkkmYLu7qHhYpwtr@bitmessage.ch>

On Tue, Apr 25, 2017 at 09:02:48PM +0200, Ilia Sergachev wrote:
> Fixes few warnings and checks in drivers/staging/ks7010/ks_wlan_net.c

What type of warnings?  What checks?  It builds just fine for me here.

You need to be very specific.

And only do one type of thing per patch, a big "fixes all types of
warnings" is not ok in a single patch.

> 
> Signed-off-by: Ilia Sergachev <BM-2cVwRgNYPK72fLRfbWfkkmYLu7qHhYpwtr@bitmessage.ch>
> Cc: devel@driverdev.osuosl.org,linux-kernel@vger.kernel.org

That last line doesn't make much sense, does it?

thanks,

greg k-h

  reply	other threads:[~2017-04-25 19:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 19:02 Ilia Sergachev
2017-04-25 19:10 ` Greg Kroah-Hartman [this message]
2017-04-25 19:56 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170425191019.GA27234@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=BM-2cVwRgNYPK72fLRfbWfkkmYLu7qHhYpwtr@bitmessage.ch \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®