From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1952180AbdDZCPP (ORCPT ); Tue, 25 Apr 2017 22:15:15 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:34706 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946709AbdDZCPF (ORCPT ); Tue, 25 Apr 2017 22:15:05 -0400 Date: Wed, 26 Apr 2017 11:14:52 +0900 From: Sergey Senozhatsky To: js1304@gmail.com Cc: Andrew Morton , Minchan Kim , Sergey Senozhatsky , linux-kernel@vger.kernel.org, kernel-team@lge.com, Joonsoo Kim Subject: Re: [PATCH v4 2/4] zram: implement deduplication in zram Message-ID: <20170426021452.GA673@jagdpanzerIV.localdomain> References: <1493167946-10936-1-git-send-email-iamjoonsoo.kim@lge.com> <1493167946-10936-3-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493167946-10936-3-git-send-email-iamjoonsoo.kim@lge.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On (04/26/17 09:52), js1304@gmail.com wrote: [..] > ret = scnprintf(buf, PAGE_SIZE, > - "%8llu %8llu %8llu %8lu %8ld %8llu %8lu\n", > + "%8llu %8llu %8llu %8lu %8ld %8llu %8lu %8llu %8llu\n", > orig_size << PAGE_SHIFT, > (u64)atomic64_read(&zram->stats.compr_data_size), > mem_used << PAGE_SHIFT, > zram->limit_pages << PAGE_SHIFT, > max_used << PAGE_SHIFT, > (u64)atomic64_read(&zram->stats.same_pages), > - pool_stats.pages_compacted); > + pool_stats.pages_compacted, > + zram_dedup_dup_size(zram), > + zram_dedup_meta_size(zram)); hm... should't we subtract zram_dedup_dup_size(zram) from ->stats.compr_data_size? we don't use extra memory for dedupped pages. or don't inc ->stats.compr_data_size for dedupped pages? for instance, same_page_write() does not inc ->stats.compr_data_size, while successful zram_dedup_find() does (in __zram_bvec_write()). -ss