From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1953737AbdDZDVJ (ORCPT ); Tue, 25 Apr 2017 23:21:09 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:48559 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1430888AbdDZDVC (ORCPT ); Tue, 25 Apr 2017 23:21:02 -0400 X-Greylist: delayed 527 seconds by postgrey-1.27 at vger.kernel.org; Tue, 25 Apr 2017 23:21:02 EDT X-ME-Sender: X-Sasl-enc: Ik9Y68gNiZxSI7N4GIHs8/B1mAue+1H+4CmPn46xBkVo 1493176334 Date: Wed, 26 Apr 2017 13:12:11 +1000 From: "Tobin C. Harding" To: Ilia Sergachev Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: ks7010: fix block comment style in ks_wlan_net.c Message-ID: <20170426031211.GB18468@eros> References: <20170425205925.20439-1-ilia.sergachev@unibas.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170425205925.20439-1-ilia.sergachev@unibas.ch> X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 25, 2017 at 10:59:25PM +0200, Ilia Sergachev wrote: > This is a patch to the ks_wlan_net.c file that fixes up the following warning > found by the checkpatch.pl tool: > WARNING: Block comments use a trailing */ on a separate line Good work resubmitting this following Greg's comments. May I suggest some ways to hasten your success. Note firstly, that I appreciate that writing the gitlog message is very difficult to do well. I am by no means an expert. - You don't need to mention the file, especially not in the subject. We can see the files changed from the patch itself. - You should refrain from using 'this patch', the subject (as in subject, object, verb) is implicit. See Documentation/process/submitting-patches.rst (Section 2: Describe your changes). Example Checkpatch emits WARNING: Block comments use a trailing */ on a separate line. Move trailing */ to separate line. Good luck, Tobin.