From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2998585AbdDZKqT (ORCPT ); Wed, 26 Apr 2017 06:46:19 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:50240 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2997741AbdDZKqN (ORCPT ); Wed, 26 Apr 2017 06:46:13 -0400 Date: Wed, 26 Apr 2017 13:45:55 +0300 From: Dan Carpenter To: "Tobin C. Harding" Cc: Ilia Sergachev , devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Staging: ks7010: style fix Message-ID: <20170426104555.6k5st7izvhapqxhg@mwanda> References: <20170425205925.20439-1-ilia.sergachev@unibas.ch> <20170426083854.18813-1-ilia.sergachev@unibas.ch> <20170426103756.GF18468@eros> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170426103756.GF18468@eros> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 26, 2017 at 08:37:56PM +1000, Tobin C. Harding wrote: > On Wed, Apr 26, 2017 at 10:38:54AM +0200, Ilia Sergachev wrote: > > Fix the style of block comments. > > Move trailing */ to a separate line. > > Checkpatch was showing: > > WARNING: Block comments use a trailing */ on a separate line. > > You are doing well Ilia. A few nitpicks > > - Your first subject was better (excluding the filname) :) it was more > descriptive. Yeah. This subject is bad. > > - staging has a small 's'. You can verify with; > $ git log --pretty=oneline drivers/staging/ks7010/ks_wlan_net.c Nah.. It can go either way. No one cares. regards, dan carpenter