From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968405AbdD0LAx (ORCPT ); Thu, 27 Apr 2017 07:00:53 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:56140 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965199AbdD0LAn (ORCPT ); Thu, 27 Apr 2017 07:00:43 -0400 From: Arnd Bergmann To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: Arnd Bergmann , Vinod Koul , Jeeja KP , Jayachandran B , Senthilnathan Veppur , "Subhransu S. Prusty" , Ramesh Babu , G Kranthi , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: Intel: Skylake: fix uninitialized pointer use Date: Thu, 27 Apr 2017 12:59:58 +0200 Message-Id: <20170427110014.2316664-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:j495f8R0XuL0pLTkJYIs71JmjABMFVaSI+bj5i3S4sXF49lncNm DNhomschYADY2OwfcuV0Udr4QQSmVDwF9ecwqjAcbRpWSUM8Qe7ZZm5adPXSRYe9BLw+1Bh AYn/hZS+DlrqA8BHmLMPI7MwMbSHvgD3nW7m/qJuVVsAwueJbq/7FZhS8XHL8bk2XDYOC1O BYx/yl6IJObtSOT5IOaUQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:oKck1Id7X+E=:dKDfJLQeYD5Alhfo3xWNGb b1Sw4B6MqoO+o0XqNcR+tYikRwVE6UNwyyYzUTnlwLNUpMLCstSB17U/vljVQSxSIeTmI8N8E FW7as5Be4uAFxkDNnvVu8cnuuz3OkLqem3c6a1X/aRj6YO7libfOUHbIasqEZUukotKm2LbqM Ex33nfy8sxaSp/85O+hcfZWoe83H1h0vqokoJFwXo6VzQdkxffSVCMTRUrF8SuH8b/EQVPq5+ N9LMrsJJvx7cU8Alt6qOGD2YG78IQhkifawQj/5ZvnXbu8JUo+y8/Jp+xMmyoaZmqSv91kDdt +DqBFnrCU39IK+CopGsuFbw4+8sR8wyNl/BJhYPb/kLVUGzBEJjc/M5FtPwKjkkCn34x3Wzw8 617bISAdLmoph0l4C13gC3SgoUUo0yAKtf1n5IbIY+UIYMRK9GuV1qB1cJLBBw7mrug4ZK6kX 4Dh9/Lg/WADQOzNbAzc4fhM7TKEst/zXaxsPrcCL1MDBOWJP2UZYOaKv+ar0pLSRoMBnUQJda bIZjU6enQSl6oOmmyUke2VsohJBInKWy7KL+kmI3nZMW8xN3zraUS+By+XhgCYtb2eMf1R2Nc rs7byK0R42L6OmdkrRAKpGhotTP7+5uN7+hgsZupFgIuG4/8e3IFr3hJci90kxjGr8GuuoYno xhniw2r086aLgvBlh34KHPgemP+DxYvn/V72YXRgn48h0vjLygeo0iDZ7+gUb+htm6/E= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The error handling in bxt_sst_dsp_init() got changed in a way that it now derefences an uninitialized pointer when printing a warning about the device not being found: sound/soc/intel/skylake/bxt-sst.c: In function 'bxt_sst_dsp_init': sound/soc/intel/skylake/bxt-sst.c:567:14: error: 'skl' may be used uninitialized in this function [-Werror=maybe-uninitialized] As we do have a valid device pointer available at the call site, let's use that instead. Fixes: 9fe9c7119283 ("ASoC: Intel: Skylake: Move sst common initialization to a helper function") Signed-off-by: Arnd Bergmann --- sound/soc/intel/skylake/bxt-sst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/skylake/bxt-sst.c b/sound/soc/intel/skylake/bxt-sst.c index fde4bc0f35b0..f5e7dbb1ba39 100644 --- a/sound/soc/intel/skylake/bxt-sst.c +++ b/sound/soc/intel/skylake/bxt-sst.c @@ -564,7 +564,7 @@ int bxt_sst_dsp_init(struct device *dev, void __iomem *mmio_base, int irq, ret = skl_sst_ctx_init(dev, irq, fw_name, dsp_ops, dsp, &skl_dev); if (ret < 0) { - dev_err(skl->dev, "%s: no device\n", __func__); + dev_err(dev, "%s: no device\n", __func__); return ret; } -- 2.9.0