From: Steven Rostedt <rostedt@goodmis.org>
To: Pratyush Anand <panand@redhat.com>
Cc: linux-kernel@vger.kernel.org, dyoung@redhat.com, xlpang@redhat.com
Subject: Re: [trace-cmd Patch RFC] trace-cmd: top: A new interface to detect peak memory
Date: Thu, 27 Apr 2017 12:49:40 -0400 [thread overview]
Message-ID: <20170427124940.62ca6a06@gandalf.local.home> (raw)
In-Reply-To: <727920fa-219c-6d8d-3ba6-2f0553b2cbdc@redhat.com>
On Thu, 27 Apr 2017 19:32:43 +0530
Pratyush Anand <panand@redhat.com> wrote:
> I will implement your review comments and will send next revision.
> However, I had couple of observation which I was unable to justify:
>
> # ./trace-cmd top -s /tmp/test
> # ./trace-cmd top -p /tmp/test | grep trace-cmd
> 15292 trace-cmd 22144 15808
What does it give for your /tmp/test ?
Note, tracing doesn't start till after trace-cmd is loaded. Everything
before is not going to be seen.
> Here,15292 is the pid of trace-cmd task
> 22144 KB is the peak memory usage
> 15808 KB is the current memory usage
>
> Now check rss component from statm
> # cat /proc/15292/statm
> 50 35 23 7 0 12 0 36
>
> This is a result on ARM64/64KB page size. Therefore, as per statm rss is 35
> pages = 35*64 = 2240KB
> I patched my kernel [2] for test purpose, so that statm reports peak memory as
> well. Here, the last extra entry in statm output is peak memory and it is 36
> pages = 2304KB.
> So, this is a huge difference between what has been reported by statm and what
> we get from trace-cmd.
> I understand that `trace-cmd top` output would only be approximate, because
> many of the memory could be allocated by task and freed in interrupt context.
> So, many a time it can differ. But, is such a huge difference justified? If
> yes, can we count on the output of this utility to find early boot time oom
> issues?
Doesn't it only just trace the memory usage of when the tracing starts?
-- Steve
>
>
> [1]
> https://github.com/pratyushanand/trace-cmd/commit/602c2cd96aa613633ad20c6d382e41f7db37a2a4
> [2]
> https://github.com/pratyushanand/linux/commit/197e2045361b6b70085c46c78ea6607d8afce517
next prev parent reply other threads:[~2017-04-27 16:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 15:02 Pratyush Anand
2017-04-26 14:01 ` Steven Rostedt
2017-04-27 14:02 ` Pratyush Anand
2017-04-27 16:49 ` Steven Rostedt [this message]
2017-04-27 17:33 ` Pratyush Anand
2017-04-28 2:27 ` Steven Rostedt
2019-01-04 4:02 ` Steven Rostedt
2019-01-04 4:07 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170427124940.62ca6a06@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=dyoung@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=panand@redhat.com \
--cc=xlpang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®