From: David Miller <davem@davemloft.net>
To: briannorris@chromium.org
Cc: joe@perches.com, apw@canonical.com, linux-kernel@vger.kernel.org,
herbert@gondor.apana.org.au, mingo@redhat.com,
akpm@linux-foundation.org
Subject: Re: [PATCH] checkpatch: don't encourage new code to use "networking" style comments
Date: Fri, 28 Apr 2017 15:31:33 -0400 (EDT) [thread overview]
Message-ID: <20170428.153133.431048256400360136.davem@davemloft.net> (raw)
In-Reply-To: <20170428192721.GA72697@google.com>
From: Brian Norris <briannorris@chromium.org>
Date: Fri, 28 Apr 2017 12:27:22 -0700
> On Fri, Apr 28, 2017 at 11:24:18AM -0700, Joe Perches wrote:
>> On Fri, 2017-04-28 at 10:55 -0700, Brian Norris wrote:
>> I believe the only person that actually cares about
>> the networking
>> comment style is David Miller.
>
> Which is why I've CC'd him. If even *he* doesn't care about having
> this warning in checkpatch, then why should anyone else?
Well it potentially saves one round trip for patch submissions.
What I'm not going to do is let people start using different comment
style even for new code in files like net/core/whatever.c after I've
spent nearly two decades getting them to be one way so far.
next prev parent reply other threads:[~2017-04-28 19:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 17:55 Brian Norris
2017-04-28 18:24 ` Joe Perches
2017-04-28 19:27 ` Brian Norris
2017-04-28 19:31 ` David Miller [this message]
2017-04-28 19:51 ` Brian Norris
2017-04-28 21:05 ` Joe Perches
2017-04-28 19:36 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428.153133.431048256400360136.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=briannorris@chromium.org \
--cc=herbert@gondor.apana.org.au \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®