From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1164702AbdD1GZi (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Apr 2017 02:25:38 -0400
Received: from mail-wr0-f194.google.com ([209.85.128.194]:34564 "EHLO
        mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1164001AbdD1GZb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Apr 2017 02:25:31 -0400
Date: Fri, 28 Apr 2017 08:25:27 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, Dave Young <dyoung@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, x86@kernel.org,
        Kees Cook <keescook@chromium.org>, Yinghai Lu <yinghai@kernel.org>,
        Borislav Petkov <bp@suse.de>, Dave Jiang <dave.jiang@intel.com>,
        Thomas Garnier <thgarnie@google.com>
Subject: Re: [PATCH v2] x86/KASLR: Use old ident map page table if physical
 randomization failed
Message-ID: <20170428062527.qx6wvh7ctdinzezs@gmail.com>
References: <1493278940-5885-1-git-send-email-bhe@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1493278940-5885-1-git-send-email-bhe@redhat.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Baoquan He <bhe@redhat.com> wrote:

> Dave found kdump kernel with kaslr enabled will reset to bios immediately
> if physical randomization failed to find a new position for kernel. But
> kernel with 'nokaslr' option works in this case.
> 
> The reason is kaslr will install a new page table for ident mapping,
> while it missed to consider building ident mapping for original area
> of kernel if kaslr failed on physical randomization.
> 
> This only happens in kexec/kdump kernel. Since ident mapping has been
> built for kexec/kdump in 1st kernel for the whole memory by calling
> init_pgtable(). Here if physical randomizaiton failed, it won't build
> ident mapping for the original area of kernel but change to new page
> table '_pgtable'. Then kernel will reset to bios immediately caused by
> no ident mapping.
> 
> While normal kernel won't be impacted because it comes here via
> startup_32() and cr3 will be _pgtable already. In startup_32() ident
> mapping is built for 0~4G area. In kaslr We just append to the existing
> area instead of entirely overwriting it for on-demand ident mapping
> building. So ident mapping for the original area of kernel is still
> there.
> 
> So for fixing it,  We just switch to the new ident mapping page table
> when physical kaslr succeeds. Otherwise we keep the old page table
> unchanged just like nokaslr does.
> 
> Signed-off-by: Baoquan He <bhe@redhat.com>
> Signed-off-by: Dave Young <dyoung@redhat.com>
> Acked-by: Kees Cook <keescook@chromium.org>

That's not a valid signoff chain. I made it:

 Reported-by: Dave Young <dyoung@redhat.com>
 Signed-off-by: Baoquan He <bhe@redhat.com>
 Acked-by: Dave Young <dyoung@redhat.com>
 Acked-by: Kees Cook <keescook@chromium.org>

(Let me know if that's not the proper authorship chain.)

Thanks,

	Ingo