From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424389AbdD1Hat (ORCPT ); Fri, 28 Apr 2017 03:30:49 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50190 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424371AbdD1Hal (ORCPT ); Fri, 28 Apr 2017 03:30:41 -0400 Date: Fri, 28 Apr 2017 09:30:31 +0200 From: Greg Kroah-Hartman To: Andrea della Porta Cc: Oleg Drokin , Andreas Dilger , James Simmons , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: staging: lustre: lustre: llite: file.c - fixed sparse warning about different fmode_t type Message-ID: <20170428073031.GB29107@kroah.com> References: <20170424065311.GA32527@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170424065311.GA32527@gmail.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 24, 2017 at 07:53:11AM +0100, Andrea della Porta wrote: > fixed a couple of sparse warning complaining about type mismatch. That's really vague, please be specific. > > Signed-off-by: Andrea della Porta > --- > drivers/staging/lustre/lustre/include/lustre_intent.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/include/lustre_intent.h b/drivers/staging/lustre/lustre/include/lustre_intent.h > index ed2b6c6..c036633 100644 > --- a/drivers/staging/lustre/lustre/include/lustre_intent.h > +++ b/drivers/staging/lustre/lustre/include/lustre_intent.h > @@ -38,7 +38,7 @@ > struct lookup_intent { > int it_op; > int it_create_mode; > - __u64 it_flags; > + fmode_t it_flags; Are you sure? Why? What exact warning did this "fix"? thanks, greg k-h