From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992799AbdD1L7T (ORCPT ); Fri, 28 Apr 2017 07:59:19 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39564 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992764AbdD1L7A (ORCPT ); Fri, 28 Apr 2017 07:59:00 -0400 Date: Fri, 28 Apr 2017 12:33:47 +0200 From: "gregkh@linuxfoundation.org" To: Lynn Lei Cc: "sudipm.mukherjee@gmail.com" , "devel@driverdev.osuosl.org" , "linux-fbdev@vger.kernel.org" , "teddy.wang@siliconmotion.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] staging: sm750fb: Combine set GPIO 30 & 31 into one statement Message-ID: <20170428103347.GA7868@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 25, 2017 at 03:53:02PM +0000, Lynn Lei wrote: > Combine two separate set GPIO(30 & 31) operations into one statement. Why? > > Signed-off-by: Lynn Lei > --- > drivers/staging/sm750fb/ddk750_hwi2c.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_hwi2c.c b/drivers/staging/sm750fb/ddk750_hwi2c.c > index 68716ef7cb06..ddb7a6dc265a 100644 > --- a/drivers/staging/sm750fb/ddk750_hwi2c.c > +++ b/drivers/staging/sm750fb/ddk750_hwi2c.c > @@ -49,8 +49,7 @@ void sm750_hw_i2c_close(void) > > /* Set GPIO 30 & 31 back as GPIO pins */ > value = peek32(GPIO_MUX); > - value &= ~GPIO_MUX_30; > - value &= ~GPIO_MUX_31; > + value &= ~(GPIO_MUX_30 | GPIO_MUX_31); Why does this matter? thanks, greg k-h