From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425880AbdD1NA3 (ORCPT ); Fri, 28 Apr 2017 09:00:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:45708 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1423106AbdD1NAV (ORCPT ); Fri, 28 Apr 2017 09:00:21 -0400 From: Takashi Iwai To: Al Viro Cc: "Eric W . Biederman" , Andrew Morton , Tristan Ye , linux-kernel@vger.kernel.org Subject: [PATCH] proc: Fix unbalanced hard link numbers Date: Fri, 28 Apr 2017 15:00:15 +0200 Message-Id: <20170428130015.14775-1-tiwai@suse.de> X-Mailer: git-send-email 2.12.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org proc_create_mount_point() forgot to increase the parent's nlink, and it resulted in unbalanced hard link numbers, e.g. /proc/fs shows one less than expected. Fixes: eb6d38d5427b ("proc: Allow creating permanently empty directories...") Cc: stable@vger.kernel.org Reported-by: Tristan Ye Signed-off-by: Takashi Iwai --- fs/proc/generic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/proc/generic.c b/fs/proc/generic.c index ee27feb34cf4..9425c0d97262 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@ -472,6 +472,7 @@ struct proc_dir_entry *proc_create_mount_point(const char *name) ent->data = NULL; ent->proc_fops = NULL; ent->proc_iops = NULL; + parent->nlink++; if (proc_register(parent, ent) < 0) { kfree(ent); parent->nlink--; -- 2.12.2