From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1036000AbdD1NeR (ORCPT ); Fri, 28 Apr 2017 09:34:17 -0400 Received: from merlin.infradead.org ([205.233.59.134]:52350 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162806AbdD1Ncg (ORCPT ); Fri, 28 Apr 2017 09:32:36 -0400 Message-Id: <20170428132502.749421763@infradead.org> User-Agent: quilt/0.63-1 Date: Fri, 28 Apr 2017 15:20:06 +0200 From: Peter Zijlstra To: mingo@kernel.org, lvenanci@redhat.com Cc: lwang@redhat.com, riel@redhat.com, efault@gmx.de, tglx@linutronix.de, linux-kernel@vger.kernel.org, peterz@infradead.org Subject: [PATCH 08/14] sched/topology: Move comment about asymmetric node setups References: <20170428131958.893188882@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline; filename=lauro_ramos_venancio-sched_topology-move_comment_about_asymmetric_node_setups.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cc: lwang@redhat.com Cc: Ingo Molnar Cc: Mike Galbraith Cc: Thomas Gleixner Cc: riel@redhat.com Signed-off-by: Lauro Ramos Venancio Signed-off-by: Peter Zijlstra (Intel) Link: http://lkml.kernel.org/r/1492717903-5195-4-git-send-email-lvenanci@redhat.com --- kernel/sched/topology.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -495,14 +495,6 @@ enum s_alloc { /* * Build an iteration mask that can exclude certain CPUs from the upwards * domain traversal. - * - * Asymmetric node setups can result in situations where the domain tree is of - * unequal depth, make sure to skip domains that already cover the entire - * range. - * - * In that case build_sched_domains() will have terminated the iteration early - * and our sibling sd spans will be empty. Domains should always include the - * CPU they're built on, so check that. */ static void build_group_mask(struct sched_domain *sd, struct sched_group *sg) { @@ -590,7 +582,16 @@ build_overlap_sched_groups(struct sched_ sibling = *per_cpu_ptr(sdd->sd, i); - /* See the comment near build_group_mask(). */ + /* + * Asymmetric node setups can result in situations where the + * domain tree is of unequal depth, make sure to skip domains + * that already cover the entire range. + * + * In that case build_sched_domains() will have terminated the + * iteration early and our sibling sd spans will be empty. + * Domains should always include the CPU they're built on, so + * check that. + */ if (!cpumask_test_cpu(i, sched_domain_span(sibling))) continue;