From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035273AbdD1O0p (ORCPT ); Fri, 28 Apr 2017 10:26:45 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:42477 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938127AbdD1O0f (ORCPT ); Fri, 28 Apr 2017 10:26:35 -0400 Date: Fri, 28 Apr 2017 17:26:17 +0300 From: Dan Carpenter To: Ilia Sergachev Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: ks7010: remove line continuations in quoted strings Message-ID: <20170428142617.wdqlotp7ehzbe4ag@mwanda> References: <20170428141928.31893-1-ilia.sergachev@unibas.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170428141928.31893-1-ilia.sergachev@unibas.ch> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 28, 2017 at 04:19:28PM +0200, Ilia Sergachev wrote: > Checkpatch emits WARNING: Avoid line continuations in quoted strings. > > Remove line continuations - split strings using quotes. > > Signed-off-by: Ilia Sergachev > --- > drivers/staging/ks7010/ks_hostif.c | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c > index 7151f16e2f9c..a0c632a52f48 100644 > --- a/drivers/staging/ks7010/ks_hostif.c > +++ b/drivers/staging/ks7010/ks_hostif.c > @@ -191,9 +191,15 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info) > wireless_send_event(netdev, SIOCGIWAP, &wrqu, NULL); > } > DPRINTK(4, "\n Link AP\n"); > - DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \ > - essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ > - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); > + DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n" > + " essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n" > + " channel=%d\n rssi=%d\n sq=%d\n capability=%04X\n", > + ap->bssid[0], ap->bssid[1], ap->bssid[2], > + ap->bssid[3], ap->bssid[4], ap->bssid[5], > + &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], > + ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], > + ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], > + ap->channel, ap->rssi, ap->sq, ap->capability); Could you indent it like this: DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n" " essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n" " channel=%d\n rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); And actually it might be more readable to break it up more: DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n" " essid=%s\n" " rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n" " channel=%d\n" " rssi=%d\n" " sq=%d\n" " capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); Except that's not really how newlines are supposed to work in dmesg... Whatever. regards, dan carpenter