From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1952299AbdD2HG3 (ORCPT ); Sat, 29 Apr 2017 03:06:29 -0400 Received: from botnar.kaiser.cx ([176.28.20.183]:58578 "EHLO botnar.kaiser.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1166339AbdD2HGV (ORCPT ); Sat, 29 Apr 2017 03:06:21 -0400 Date: Sat, 29 Apr 2017 09:05:15 +0200 From: Martin Kaiser To: Andy Shevchenko Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry Message-ID: <20170429070515.GB29622@botnar.kaiser.cx> References: <1488234485-26111-1-git-send-email-martin@kaiser.cx> <1492453377-23796-1-git-send-email-martin@kaiser.cx> <1492453377-23796-2-git-send-email-martin@kaiser.cx> <20170418043110.GA30463@kroah.com> <20170418075131.GA15328@botnar.kaiser.cx> <20170418081542.GA2051@kroah.com> <20170418091102.GA17375@botnar.kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andy, Thus wrote Andy Shevchenko (andy.shevchenko@gmail.com): > On Tue, Apr 18, 2017 at 12:11 PM, Martin Kaiser wrote: > > checkpatch is asking for a 4 digit octal number. And at least for me, > > 0444 makes it clearer what the permissions actually are. Yes, somewhere > > in the code, I can dig up that 0 is changed to 0444... > Aren't 0 and 0444 different by meaning? my undestanding is that proc_create() calls proc_create_data(), where if ((mode & S_IALLUGO) == 0) mode |= S_IRUGO; sets mode to 0444 when it was 0. Best regards, Martin (added the lkml back to Cc, I removed it by accident in an earlier mail)