From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
dietmar.eggemann@arm.com, Morten.Rasmussen@arm.com,
yuyang.du@intel.com, pjt@google.com, bsegall@google.com
Subject: Re: [PATCH v2] sched/fair: update scale invariance of PELT
Date: Mon, 1 May 2017 11:00:26 +0200 [thread overview]
Message-ID: <20170501090026.kht6tsttn6dirbrw@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20170428220924.mxzs43zyvfqww2ze@hirez.programming.kicks-ass.net>
On Sat, Apr 29, 2017 at 12:09:24AM +0200, Peter Zijlstra wrote:
> On Mon, Apr 10, 2017 at 11:18:29AM +0200, Vincent Guittot wrote:
> > +++ b/include/linux/sched.h
> > @@ -313,6 +313,7 @@ struct load_weight {
> > */
> > struct sched_avg {
> > u64 last_update_time;
> > + u64 stolen_idle_time;
> > u64 load_sum;
> > u32 util_sum;
> > u32 period_contrib;
>
> > + if (sa->util_sum < (LOAD_AVG_MAX * 1000)) {
> > + /*
> > + * Add the idle time stolen by running at lower compute
> > + * capacity
> > + */
> > + delta += sa->stolen_idle_time;
> > + }
> > + sa->stolen_idle_time = 0;
>
>
> So I was wondering if stolen_idle_time really needs to be a u64. Afaict
> we'll be at LOAD_AVG_MAX after LOAD_AVG_MAX_N periods, or LOAD_AVG_MAX_N
> * LOAD_AVG_PERIOD time, which ends up being 11040.
* 1024 or course, but still easily fits in u32.
next prev parent reply other threads:[~2017-05-01 9:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 9:18 Vincent Guittot
2017-04-10 17:38 ` Peter Zijlstra
2017-04-11 7:52 ` Vincent Guittot
2017-04-11 8:53 ` Peter Zijlstra
2017-04-11 9:40 ` Vincent Guittot
2017-04-11 10:41 ` Peter Zijlstra
2017-04-11 10:49 ` Peter Zijlstra
2017-04-11 13:09 ` Vincent Guittot
2017-04-12 11:28 ` Peter Zijlstra
2017-04-12 14:50 ` Vincent Guittot
2017-04-12 15:44 ` Peter Zijlstra
2017-04-13 9:42 ` Vincent Guittot
2017-04-13 13:32 ` Peter Zijlstra
2017-04-13 14:59 ` Vincent Guittot
2017-04-13 18:06 ` Peter Zijlstra
2017-04-14 8:47 ` Vincent Guittot
2017-04-11 12:08 ` Vincent Guittot
2017-04-11 9:12 ` Peter Zijlstra
2017-04-11 9:46 ` Vincent Guittot
2017-04-13 13:39 ` Peter Zijlstra
2017-04-13 15:16 ` Vincent Guittot
2017-04-13 16:13 ` Peter Zijlstra
2017-04-14 8:49 ` Vincent Guittot
2017-04-19 16:31 ` Vincent Guittot
2017-04-28 15:52 ` Morten Rasmussen
2017-04-28 17:08 ` Dietmar Eggemann
2017-05-03 17:11 ` Vincent Guittot
2017-04-28 22:09 ` Peter Zijlstra
2017-05-01 9:00 ` Peter Zijlstra [this message]
2017-05-02 13:38 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501090026.kht6tsttn6dirbrw@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Morten.Rasmussen@arm.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pjt@google.com \
--cc=vincent.guittot@linaro.org \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®