From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751814AbdEBIQ6 (ORCPT ); Tue, 2 May 2017 04:16:58 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35231 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbdEBIQz (ORCPT ); Tue, 2 May 2017 04:16:55 -0400 Date: Tue, 2 May 2017 10:16:51 +0200 From: Daniel Vetter To: Alex Deucher Cc: Eric Anholt , Daniel Vetter , Mark Rutland , "devicetree@vger.kernel.org" , Rob Herring , Linux Kernel Mailing List , dri-devel Subject: Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D. Message-ID: <20170502081651.gnbccjsm4nr2bxmv@phenom.ffwll.local> Mail-Followup-To: Alex Deucher , Eric Anholt , Mark Rutland , "devicetree@vger.kernel.org" , Rob Herring , Linux Kernel Mailing List , dri-devel References: <20170418191157.18517-1-eric@anholt.net> <20170418191157.18517-2-eric@anholt.net> <8760i046zw.fsf@eliezer.anholt.net> <87wpadtlsl.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.9.0-2-amd64 User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 24, 2017 at 10:26:45AM -0400, Alex Deucher wrote: > On Fri, Apr 21, 2017 at 6:53 PM, Eric Anholt wrote: > > Daniel Vetter writes: > > > >> On Wed, Apr 19, 2017 at 7:55 PM, Eric Anholt wrote: > >>> Daniel Vetter writes: > >>>> On Tue, Apr 18, 2017 at 9:11 PM, Eric Anholt wrote: > >>>>> The FBDEV initialization would throw an error in dmesg, when we just > >>>>> want to silently not initialize fbdev on a V3D-only VC4 instance. > >>>>> > >>>>> Signed-off-by: Eric Anholt > >>>> > >>>> Hm, this shouldn't be an error really, you might want to hotplug more > >>>> connectors later on. What exactly complains? > >>> > >>> drm_fb_helper_init() throws an error if the passed in connector count is > >>> 0, so drm_fb_cma_helper() printks an error. > >> > >> Oh, _that_ thing. The error in there is correct, but (almost) everyone > >> gets this parameter wrong. This isn't the max number of connectors the > >> fb helper will light up, but just the max number of connectors _per_ > >> crtc when driving in hw clone mode. There's two problems with that: > >> - fb helpers don't support hw clone mode, we select 1:1 crtcs for each > >> active connector > >> - I mentioned that everyone gets this wrong? > >> > >> If you're moderately bored it'd be great to nuke the max_connector > >> argument from drm_fb_helper_init, and hard-code it to 1 (with a big > >> comment explaining that this needs to be changed, probably with > >> dynamic reallocation, once someone gets around to implementing hw > >> clone mode). > >> > >> If you're less bored, just hardcode this to 1 in vc4 and done. Plus a > >> TODO.rst entry would be great in that case. > > > > If I'm driving a GPU with no display subsystem at all, it seems like I > > shouldn't initialize fbdev for it, right? > > That's what we do for radeon/amdgpu on hw without display blocks. Yeah I got slightly distracted with the error :-) Still might make sense to put this logic into the helpers, if there's no crtc then don't bother initializing the fbcon. But imo the better cleanup is getting rid of the connectors parameter, since most drivers get it wrong, then respin the vc4 patch to explain what it's really doing (it's not about the error really, it's about not registering and fbdev that's not doing anything). -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch