From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751420AbdEBOtE (ORCPT ); Tue, 2 May 2017 10:49:04 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:34286 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbdEBOtC (ORCPT ); Tue, 2 May 2017 10:49:02 -0400 Date: Tue, 2 May 2017 22:48:35 +0800 From: Geliang Tang To: Ivan Hu Cc: Matt Fleming , Ard Biesheuvel , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] efi/efi_test: drop useless kfree Message-ID: <20170502144835.3jpwrdw6shnfr5g2@ThinkPad> References: <427b03b5f10b41014818b9e78f79da9581b213df.1493383416.git.geliangtang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 02, 2017 at 03:11:45PM +0800, ivanhu wrote: > > > On 04/29/2017 09:42 AM, Geliang Tang wrote: > > Drop useless kfree when memdup_user() failed, since we have already > > called kfree in memdup_user(). > > > > Signed-off-by: Geliang Tang > > --- > > drivers/firmware/efi/test/efi_test.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/firmware/efi/test/efi_test.c b/drivers/firmware/efi/test/efi_test.c > > index 08129b7..00332ae 100644 > > --- a/drivers/firmware/efi/test/efi_test.c > > +++ b/drivers/firmware/efi/test/efi_test.c > > @@ -261,10 +261,8 @@ static long efi_runtime_set_variable(unsigned long arg) > > } > > data = memdup_user(setvariable.data, setvariable.data_size); > > - if (IS_ERR(data)) { > > - kfree(name); > You mean "name" or "data"? > Sorry, it's my mistake. The original code is correct. Please ignore this patch. -Geliang > Cheers, > Ivan > > > + if (IS_ERR(data)) > > return PTR_ERR(data); > > - } > > status = efi.set_variable(name, &vendor_guid, > > setvariable.attributes,