From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751730AbdEBOzI (ORCPT ); Tue, 2 May 2017 10:55:08 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:56150 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751492AbdEBOzF (ORCPT ); Tue, 2 May 2017 10:55:05 -0400 Date: Tue, 2 May 2017 16:54:53 +0200 From: Maxime Ripard To: Rob Herring Cc: Chen-Yu Tsai , David Airlie , Mark Rutland , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 1/9] dt-bindings: display: sun4i: Add component endpoint ID numbering scheme Message-ID: <20170502145453.3moqzsr3venpn4mu@lukather> References: <20170421083857.29636-1-wens@csie.org> <20170421083857.29636-2-wens@csie.org> <20170428134841.cc5jrqhunh2rxhog@rob-hp-laptop> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yyfdqyfvjibu4hc6" Content-Disposition: inline In-Reply-To: <20170428134841.cc5jrqhunh2rxhog@rob-hp-laptop> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yyfdqyfvjibu4hc6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Apr 28, 2017 at 08:48:41AM -0500, Rob Herring wrote: > On Fri, Apr 21, 2017 at 04:38:49PM +0800, Chen-Yu Tsai wrote: > > The Allwinner display pipeline contains many hardware components, some > > of which can consume data from one of multiple upstream components. > > The numbering scheme of these components must be encoded into the device > > tree so the driver can figure out which component out of two or more of > > the same type it is supposed to use or program. > >=20 > > This patch adds the constraint that local endpoint IDs must be the index > > or number of the remote endpoint's hardware block, for all components > > in the display pipeline up to the TCONs. > >=20 > > Signed-off-by: Chen-Yu Tsai > > --- > > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 10 +++= +++++++ > > 1 file changed, 10 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.= txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > index 57a8d0610062..7acdbf14ae1c 100644 > > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > @@ -4,6 +4,16 @@ Allwinner A10 Display Pipeline > > The Allwinner A10 Display pipeline is composed of several components > > that are going to be documented below: > > =20 > > +For the input port of all components up to the TCON in the display > > +pipeline, if there are multiple components, the local endpoint IDs > > +must correspond to the index of the upstream block. For example, if > > +the remote endpoint is Frontend 1, then the local endpoint ID must > > +be 1. > > + > > +Conversely, for the output ports of the same group, the remote endpoint > > +ID must be the index of the local hardware block. If the local backend > > +is backend 1, then the remote endpoint ID must be 1. >=20 > It would be clearer if you just explicitly listed IDs and their=20 > connections. From how this is worded, it would not work if you had=20 > connections like this: >=20 > DevA 0 > DevA 1 > DevB 0 > DevB 1 >=20 > These would need to be endpoints 0-3 in TCON, and that doesn't reflect=20 > the remote devices' index. Chen-Yu, can you send a patch to rephrase the doc that way? Thanks, Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --yyfdqyfvjibu4hc6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAABCAAGBQJZCJ29AAoJEBx+YmzsjxAgIZwP/jqybAM1LgmUZH+dNyB9kZIM cUPJuRxNsanv6kncNkhgmFgOD1swZviFkF9/Pw0vEbR4WMLHAQotLJn2brwXRDon 9vrHrBPgO0Zd79wMC7ATSfyT073Qc3Vxo9o+AtTvKR42EmnfIyZ2tU8pp9PVK0rh QFaymwSPYwFjDE4urn47ArWIAAU+53luCLxAfrEpkJm7xmQkrTHX1qloWOnOvj2m IZ8g2WOO3NC3631uukKdZvcKssqkzj/C3rcSzmwD37V7vkdNQpH93K6flZhYUivb qdzRW9Pn/0mB9vUUtAIXRTyzYkP8ENKuABXoSfz1NxPpcj7/mOZoD74Yd8A5ZyXL HlkI3QsIVDjeEM7cW6nmirzyxzLEZHPr+uXQ08wNXGOA118Gx5eaYmWuKWZUYm20 Vuf+2jMeehiOHKKrTgi6HpjlWllNP280aEm+dDKr7jAMvfQGwMC6n7z+1JTqCTew VkZ+12FRMT47IFa7QYP//KpbpU5S3L35MSSBfiPk5w8+MC1k0J8tJH24hwoILoB/ bdp8gkLMkrp/a3zIsauGghrb9ItmSpILONOSk26GLPzBBzxEvX4STBCHdIPO5XdY F0dicWKGOewGx4I1uw/GWIkxW3cFCQ1UdcZe0Dxx3ZeRp8Fc1woE9fQYpZnG3fBj vZNj3nGiAO9SQJwnT59y =vMCH -----END PGP SIGNATURE----- --yyfdqyfvjibu4hc6--