From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751647AbdEBSuM (ORCPT ); Tue, 2 May 2017 14:50:12 -0400 Received: from mail-yw0-f174.google.com ([209.85.161.174]:33755 "EHLO mail-yw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346AbdEBSuK (ORCPT ); Tue, 2 May 2017 14:50:10 -0400 Date: Tue, 2 May 2017 14:50:02 -0400 From: Sean Paul To: Jeffy Chen Cc: linux-kernel@vger.kernel.org, tfiga@chromium.org, dbasehore@chromium.org, seanpaul@chromium.org, dianders@chromium.org, mark.yao@rock-chips.com, Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, David Airlie , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drm/rockchip: analogix_dp: Remove unused check and variables Message-ID: <20170502185002.ll3gcg4y2p5astvu@art_vandelay> References: <1493469547-2121-1-git-send-email-jeffy.chen@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493469547-2121-1-git-send-email-jeffy.chen@rock-chips.com> User-Agent: NeoMutt/20170306-66-6ddb52-dirty (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 29, 2017 at 08:39:07PM +0800, Jeffy Chen wrote: > Remove unused check and variables after: > drm/rockchip: Set line flag config register in vop_crtc_enable > > Signed-off-by: Jeffy Chen > > --- Applied to -misc-next, thanks. Sean > > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > index 9bfdbc6..1bccd82 100644 > --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > @@ -104,17 +104,9 @@ static void analogix_dp_psr_work(struct work_struct *work) > { > struct rockchip_dp_device *dp = > container_of(work, typeof(*dp), psr_work); > - struct drm_crtc *crtc = dp->encoder.crtc; > - int psr_state = dp->psr_state; > - int vact_end; > int ret; > unsigned long flags; > > - if (!crtc) > - return; > - > - vact_end = crtc->mode.vtotal - crtc->mode.vsync_start + crtc->mode.vdisplay; > - > ret = rockchip_drm_wait_vact_end(dp->encoder.crtc, > PSR_WAIT_LINE_FLAG_TIMEOUT_MS); > if (ret) { > @@ -123,7 +115,7 @@ static void analogix_dp_psr_work(struct work_struct *work) > } > > spin_lock_irqsave(&dp->psr_lock, flags); > - if (psr_state == EDP_VSC_PSR_STATE_ACTIVE) > + if (dp->psr_state == EDP_VSC_PSR_STATE_ACTIVE) > analogix_dp_enable_psr(dp->dev); > else > analogix_dp_disable_psr(dp->dev); > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS