From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752626AbdECJLP (ORCPT ); Wed, 3 May 2017 05:11:15 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:53778 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbdECJLK (ORCPT ); Wed, 3 May 2017 05:11:10 -0400 Date: Wed, 3 May 2017 11:10:59 +0200 From: Peter Zijlstra To: Tejun Heo Cc: Vincent Guittot , Ingo Molnar , linux-kernel , Linus Torvalds , Mike Galbraith , Paul Turner , Chris Mason , kernel-team@fb.com Subject: Re: [PATCH 1/2] sched/fair: Fix how load gets propagated from cfs_rq to its sched_entity Message-ID: <20170503091059.ndagxkaurol22wvl@hirez.programming.kicks-ass.net> References: <20170424201344.GA14169@wtj.duckdns.org> <20170424201415.GB14169@wtj.duckdns.org> <20170425181219.GA15593@wtj.duckdns.org> <20170426165123.GA17921@linaro.org> <20170501141733.shphf35psasefraj@hirez.programming.kicks-ass.net> <20170501215604.GB19079@htj.duckdns.org> <20170502081905.GA4626@worktop.programming.kicks-ass.net> <20170502083009.GA3377@worktop.programming.kicks-ass.net> <20170502200028.GA5335@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170502200028.GA5335@htj.duckdns.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 02, 2017 at 04:00:28PM -0400, Tejun Heo wrote: > Hello, Peter. > > Your changes need the following fix patch. D'0h, so much for not running my patches through a compiler ;-) > With the fix and > "sched/fair: Always propagate runnable_load_avg" applied, it seems to > work fine. The propagated number is a bit different but I don't see > noticeable difference in behavior and the new number seems to better > represent what we need. Right. Let me stare at that always propagate thing a bit. My instant worry is overhead, but yeah, we need something to make this work.