From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754183AbdECKro (ORCPT ); Wed, 3 May 2017 06:47:44 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:21534 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753572AbdECKq7 (ORCPT ); Wed, 3 May 2017 06:46:59 -0400 Date: Wed, 3 May 2017 13:46:47 +0300 From: Dan Carpenter To: Surender Polsani Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging : rtl8188eu : remove void function return Message-ID: <20170503104647.lpuoglfgonl7b2qr@mwanda> References: <1493791140-3438-1-git-send-email-surenderpolsani@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493791140-3438-1-git-send-email-surenderpolsani@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 03, 2017 at 11:29:00AM +0530, Surender Polsani wrote: > kernel coding style doesn't allow the return statement > in void function. > > Signed-off-by: Surender Polsani > --- > Changes for v2: > corrected subject line as suggested > Changes for v3: > modified from line as suggested by Greg KH > placed a semicolon in label for fixing build error > --- > drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > index d04b7fb..428996e 100644 > --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > @@ -165,7 +165,7 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter) > skip_dm: > /* Check GPIO to determine current RF on/off and Pbc status. */ > /* Check Hardware Radio ON/OFF or not */ > - return; > + ; Just get rid of the label. regards, dan carpenter