From: Quentin Schulz <quentin.schulz@free-electrons.com>
To: wg@grandegger.com, mkl@pengutronix.de, mario.huettel@gmx.net,
socketcan@hartkopp.net
Cc: Quentin Schulz <quentin.schulz@free-electrons.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
alexandre.belloni@free-electrons.com,
thomas.petazzoni@free-electrons.com
Subject: [PATCH v2 2/2] can: m_can: add deep Suspend/Resume support
Date: Wed, 3 May 2017 14:37:50 +0200 [thread overview]
Message-ID: <20170503123750.26134-2-quentin.schulz@free-electrons.com> (raw)
In-Reply-To: <20170503123750.26134-1-quentin.schulz@free-electrons.com>
This adds Power Management deep Suspend/Resume support for Bosch M_CAN
chip.
When the system resumes from deep sleep, the chip needs to be fully
reinitialized (RAM, chip, clocks, irq, candev, ...) to be functional.
Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
---
drivers/net/can/m_can/m_can.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 3f0445440146..9e0143b528f1 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -1670,12 +1670,10 @@ static __maybe_unused int m_can_suspend(struct device *dev)
struct m_can_priv *priv = netdev_priv(ndev);
if (netif_running(ndev)) {
- netif_stop_queue(ndev);
netif_device_detach(ndev);
+ m_can_close(ndev);
}
- /* TODO: enter low power */
-
priv->can.state = CAN_STATE_SLEEPING;
return 0;
@@ -1686,13 +1684,13 @@ static __maybe_unused int m_can_resume(struct device *dev)
struct net_device *ndev = dev_get_drvdata(dev);
struct m_can_priv *priv = netdev_priv(ndev);
- /* TODO: exit low power */
+ m_can_init_ram(priv);
priv->can.state = CAN_STATE_ERROR_ACTIVE;
if (netif_running(ndev)) {
+ m_can_open(ndev);
netif_device_attach(ndev);
- netif_start_queue(ndev);
}
return 0;
--
2.11.0
next prev parent reply other threads:[~2017-05-03 12:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 12:37 [PATCH v2 1/2] can: m_can: move Message RAM initialization to function Quentin Schulz
2017-05-03 12:37 ` Quentin Schulz [this message]
2017-05-03 12:40 ` [PATCH v2 2/2] can: m_can: add deep Suspend/Resume support Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170503123750.26134-2-quentin.schulz@free-electrons.com \
--to=quentin.schulz@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.huettel@gmx.net \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®