From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbdECNJv (ORCPT ); Wed, 3 May 2017 09:09:51 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:52052 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118AbdECNJq (ORCPT ); Wed, 3 May 2017 09:09:46 -0400 Date: Wed, 3 May 2017 15:09:38 +0200 From: Peter Zijlstra To: Vincent Guittot Cc: Tejun Heo , Ingo Molnar , linux-kernel , Linus Torvalds , Mike Galbraith , Paul Turner , Chris Mason , kernel-team@fb.com Subject: Re: [PATCH 2/2] sched/fair: Always propagate runnable_load_avg Message-ID: <20170503130938.44rftdivrlpz4p3b@hirez.programming.kicks-ass.net> References: <20170424201444.GC14169@wtj.duckdns.org> <20170426225202.GC11348@wtj.duckdns.org> <20170428203347.GC19364@htj.duckdns.org> <20170502215054.GC5335@htj.duckdns.org> <20170503093723.tnt53ppb23tn6buz@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 03, 2017 at 12:37:37PM +0200, Vincent Guittot wrote: > On 3 May 2017 at 11:37, Peter Zijlstra wrote: > > Of course, it could be I overlooked something, in which case, please > > tell :-) > > That's mainly based on the regression i see on my platform. I haven't > find the root cause of the regression but it's there which means that > using group_entity's load_avg to propagate child cfs_rq > runnable_load_avg breaks something (as mentioned on IRC) Right.. so looking through the code, (group) se->avg.load_avg is used in effective_load() (and thereby wake_affine()) and update_cfs_rq_h_load() (and therefore task_h_load()). So changing it will affect those two functions, which could well lead to your regression.