From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752292AbdECPQH (ORCPT ); Wed, 3 May 2017 11:16:07 -0400 Received: from mail1.bemta6.messagelabs.com ([193.109.254.114]:17021 "EHLO mail1.bemta6.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbdECPQA (ORCPT ); Wed, 3 May 2017 11:16:00 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRWlGSWpSXmKPExsUSt3Opsa7WF85 Ig2dTzCyuXDzEZDH14RM2i29XOpgsLu+aw2YxcelqZovOXf2sFhu+r2V0YPfY8LmJzWPnrLvs HptWdbJ57Hu7jM3j0C5Hj/VbrrJ4fN4kF8AexZqZl5RfkcCasfRAaMFU9oqPq8+yNzC2s3Uxc nEICaxjlHiz5ChLFyMnkFMhsez2VVYQm03AQmLyiQdsIDaLgIrE/9O/mLoYOTiEBSIl+tdWgP SKCHQxSqx+9ZgdxGEWWMIocff2dUaQBl4BB4mr63awQtiCEidnPgFbwCwgIXHwxQtmiGUGEqc XNILFJQTsJaa/v8oMskBCQF+i8VgsRNhQ4vusb1Al5hLfpjYyT2Dkn4Vk6iwkUxcwMq1i1ChO LSpLLdI1NNNLKspMzyjJTczM0TU0MNPLTS0uTkxPzUlMKtZLzs/dxAgMcAYg2MF4f2PAIUZJD iYlUV71V+yRQnxJ+SmVGYnFGfFFpTmpxYcYZTg4lCR4vT9xRgoJFqWmp1akZeYAYw0mLcHBoy TCex4kzVtckJhbnJkOkTrFqMsx597X90xCLHn5ealS4rxbQIoEQIoySvPgRsDi/hKjrJQwLyP QUUI8BalFuZklqPKvGMU5GJWEeX99BJrCk5lXArfpFdARTEBHNMtygBxRkoiQkmpgrJmgIqVj wrso9fWbq36xqjasv7b+12OIeuV09uqK/0vmit5cprbITV1EN8hCI83XTMVYZv/Sqwm6Hp4SY e+O6xe3XNqzp1f45JW5Lpfv7uZQCrV+UWi4weDhkZU3/DwSXVNKV799YcxVUCkXFZSgNeOXXI SytpTXyoraU/u/asbYNlnYeZUrsRRnJBpqMRcVJwIAYiJj5fYCAAA= X-Env-Sender: Adam.Thomson.Opensource@diasemi.com X-Msg-Ref: server-12.tower-193.messagelabs.com!1493824554!91297328!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 9.4.12; banners=-,-,- X-VirusChecked: Checked From: Adam Thomson Date: Wed, 3 May 2017 16:15:53 +0100 Subject: [PATCH] ASoC: da7213: Fix incorrect usage of bitwise '&' operator for SRM check To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai CC: Support Opensource , , , Takashi Sakamoto Message-ID: <20170503151553.AC3FE3FB6C@swsrvapps-01.diasemi.com> MIME-Version: 1.0 Content-Type: text/plain X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-ServerInfo: sw-ex-cashub01.diasemi.com, 9 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 03/05/2017 12:34:00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the SRM lock check section of code the '&' bitwise operator is used as part of checking lock status. Functionally the code works as intended, but the conditional statement is a boolean comparison so should really use '&&' logical operator instead. This commit rectifies this discrepancy. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7213.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c index 12da558..d114f33 100644 --- a/sound/soc/codecs/da7213.c +++ b/sound/soc/codecs/da7213.c @@ -771,7 +771,7 @@ static int da7213_dai_event(struct snd_soc_dapm_widget *w, ++i; msleep(50); } - } while ((i < DA7213_SRM_CHECK_RETRIES) & (!srm_lock)); + } while ((i < DA7213_SRM_CHECK_RETRIES) && (!srm_lock)); if (!srm_lock) dev_warn(codec->dev, "SRM failed to lock\n"); -- 1.9.1