From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932274AbdEDQqM (ORCPT ); Thu, 4 May 2017 12:46:12 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:57794 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755458AbdEDQqD (ORCPT ); Thu, 4 May 2017 12:46:03 -0400 Date: Thu, 04 May 2017 12:46:00 -0400 (EDT) Message-Id: <20170504.124600.627647229351638856.davem@davemloft.net> To: garsilva@embeddedor.com Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-ipv4] question about arguments position From: David Miller In-Reply-To: <20170504110755.Horde.9md-X4baf8TwOEKjGrXkelZ@gator4166.hostgator.com> References: <20170504110755.Horde.9md-X4baf8TwOEKjGrXkelZ@gator4166.hostgator.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 04 May 2017 09:04:35 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Date: Thu, 04 May 2017 11:07:54 -0500 > While looking into Coverity ID 1357474 I ran into the following piece > of code at net/ipv4/inet_diag.c:392: Because it's been this way since at least 2005, it doesn't matter if the order is correct or not. What's there is the locked in behavior exposed to userspace and changing it will break things for people.