From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755572AbdEDODG (ORCPT ); Thu, 4 May 2017 10:03:06 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:40786 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755439AbdEDOCW (ORCPT ); Thu, 4 May 2017 10:02:22 -0400 Date: Thu, 4 May 2017 16:02:20 +0200 From: Maxime Ripard To: Icenowy Zheng Cc: Rob Herring , Chen-Yu Tsai , Linus Walleij , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 03/10] pinctrl: sunxi: add A20 support to A10 driver Message-ID: <20170504140220.26kguf3trz7ocylv@lukather> References: <20170504135006.16483-1-icenowy@aosc.io> <20170504135006.16483-4-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ze3rfne35fxc5myi" Content-Disposition: inline In-Reply-To: <20170504135006.16483-4-icenowy@aosc.io> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ze3rfne35fxc5myi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 04, 2017 at 09:49:59PM +0800, Icenowy Zheng wrote: > static const struct of_device_id sun4i_a10_pinctrl_match[] =3D { > - { .compatible =3D "allwinner,sun4i-a10-pinctrl", }, > + { > + .compatible =3D "allwinner,sun4i-a10-pinctrl", > + .data =3D (void *)PINCTRL_SUN4I_A10 > + }, > + { > + .compatible =3D "allwinner,sun7i-a20-pinctrl", > + .data =3D (void *)PINCTRL_SUN7I_A20 > + }, > {} > }; This means you're going to have two drivers probing for the same device: this driver, and the old one. This is not ok, and probably introduces some corner cases. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --ze3rfne35fxc5myi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAABCAAGBQJZCzRoAAoJEBx+YmzsjxAgcocQAIJErF/Fef9K4YKH1ZJX6B7d ZJ5MGMHpih7aPgiJyZZomw5ac6Z3/mFAKYq4CBLnSRELtOLI9/O4Sa4LKrGh3nTB o/oC6ERcDcea3q+FRC2wb2j3eT4PlWqUFMVd7Rl8v5kApKxiTB684aCLg9yYGutw zS/bSoK1HT3m5p7Ip8iiiVn3Xi/+85sIZVUJNSljDlzHEJ5jrM/952TrEWrL4x/G 2JtTtLeGZ3o+/svg93Qr/9B4s6lWFqgvRwY1QZtwAPJkefGOM+IUZN3hdhBjweg8 2ydAAgC1HOzfNHgH7n3AvhHPakW5U8m34Bl7FJGo1854somArW6pkfFnAZU9RT4g qQBmSjpm/mi1riXtt/XxL2lw0vE9wE37dttTkUpVg2U/+wD4AUOil61+EqXt0Fmh S1WAgKrmI2R0VMji7GvpRpovr1hOoLn0eAF55ChM5C/5eWZBkc4cKwN25JaJ+613 A0b9r2Fov7Q8pIzFgTIqQCrOFNZDFtA2o5nU36uF9YUADudvdHGrdOwrnSWOkbwz Nm3rYevLeP8csnS80gHD1+wyrbosJv8by016gUx5fpm2YlzuVyMa02XDp15kITyf xloxqbUxUqHUrVKRpplc+d5V9Nxg0GqLkLjo/XNU05FVIzaU+LhIrUv591o5d9sg SZBiR4G3oSf3GXu92H2O =qeiz -----END PGP SIGNATURE----- --ze3rfne35fxc5myi--