From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754522AbdEDRhe (ORCPT ); Thu, 4 May 2017 13:37:34 -0400 Received: from mga01.intel.com ([192.55.52.88]:9099 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751333AbdEDRh1 (ORCPT ); Thu, 4 May 2017 13:37:27 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,287,1491289200"; d="scan'208";a="1126491697" Date: Thu, 4 May 2017 20:37:21 +0300 From: Jarkko Sakkinen To: Roberto Sassu Cc: tpmdd-devel@lists.sourceforge.net, linux-ima-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] tpm_pcr_extend() code split Message-ID: <20170504173721.fey3ubz427katwgu@intel.com> References: <20170503161911.17606-1-roberto.sassu@huawei.com> <20170504092447.mhlmwwvvecb4kdq6@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170504092447.mhlmwwvvecb4kdq6@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 04, 2017 at 12:24:47PM +0300, Jarkko Sakkinen wrote: > On Wed, May 03, 2017 at 06:19:08PM +0200, Roberto Sassu wrote: > > This patch set moves TPM 1.2 specific code to a new function called > > tpm1_pcr_extend(). The purpose of splitting is to isolate TPM 2.0 code, > > so that it can be more easily modified to handle multiple digests. > > > > With TPM 2.0, a Platform Configuration Register (PCR) could have multiple > > values, stored in locations called banks. Each bank stores the values > > of PCRs extended with the same hash algorithm. > > > > Currently, the TPM kernel driver does not take advantage of stronger > > algorithms because PCRs are always extended with a SHA1 digest, padded > > with zeros to match the length of the input for the hash algorithm > > being used. Shortly after these patches, a new patch set will be provided > > to allow callers of tpm_pcr_extend() to pass a digest for each algorithm > > supported by the TPM. > > > > In this patch set, TPM 1.2 specific code will prepare the command buffer > > with tpm_buf_init() which, in respect to the previous method, offers > > protection against buffer overflow. Moreover, CPU native to big-endian > > conversion has been removed from tags and ordinals definitions, as it is > > already done by tpm_buf_init(). > > > > Changelog: > > > > v2 > > - restored TPM_TAG_RQU_COMMAND definition in drivers/char/tpm/tpm.h > > - removed endianness conversion in TPM_TAG_RQU_COMMAND definition > > - removed '#include ' in tpm-interface.c > > and tpm-sysfs.c > > - restored TPM_ORD_ definitions in tpm-interface.c and tpm-sysfs.c > > > > Roberto Sassu (3): > > tpm: move endianness conversion of TPM_TAG_RQU_COMMAND to > > tpm_input_header > > tpm: move endianness conversion of ordinals to tpm_input_header > > tpm: move TPM 1.2 code of tpm_pcr_extend() to tpm1_pcr_extend() > > > > drivers/char/tpm/tpm-interface.c | 79 ++++++++++++++++++++++------------------ > > drivers/char/tpm/tpm-sysfs.c | 6 +-- > > drivers/char/tpm/tpm.h | 2 +- > > 3 files changed, 47 insertions(+), 40 deletions(-) > > Thanks for good quality patches! I'll test these but with quick skim > no complains whatsoever :-) 1/3 and 2/3 are now applied to master and next (which will be pulled to linux-next). /Jarkko