From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756876AbdEDTiZ (ORCPT ); Thu, 4 May 2017 15:38:25 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53166 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751791AbdEDTiX (ORCPT ); Thu, 4 May 2017 15:38:23 -0400 Date: Thu, 4 May 2017 12:38:14 -0700 From: Greg Kroah-Hartman To: Ross Lagerwall Cc: stable@vger.kernel.org, "David S. Miller" , Eric Dumazet , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 4.4-only] netlink: Allow direct reclaim for fallback allocation Message-ID: <20170504193814.GB10166@kroah.com> References: <1493801059-2828-1-git-send-email-ross.lagerwall@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493801059-2828-1-git-send-email-ross.lagerwall@citrix.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 03, 2017 at 09:44:19AM +0100, Ross Lagerwall wrote: > The backport of d35c99ff77ec ("netlink: do not enter direct reclaim from > netlink_dump()") to the 4.4 branch (first in 4.4.32) mistakenly removed > direct claim from the initial large allocation _and_ the fallback > allocation which means that allocations can spuriously fail. > Fix the issue by adding back the direct reclaim flag to the fallback > allocation. > > Fixes: 6d123f1d396b ("netlink: do not enter direct reclaim from netlink_dump()") > Signed-off-by: Ross Lagerwall > --- > > Note that this is only for the 4.4 branch as the regression is only in > this branch. Consequently, there is no corresponding upstream commit. > > I'm resending this to the linux-stable list since I now understand the > netdev maintainer only handles backports for the last couple of versions > of Linux. > Many thanks for this fix, now queued up. greg k-h