From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752441AbdEDUJe (ORCPT ); Thu, 4 May 2017 16:09:34 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:57783 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751428AbdEDUJc (ORCPT ); Thu, 4 May 2017 16:09:32 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Thu, 4 May 2017 21:09:28 +0100 From: Chris Wilson To: SF Markus Elfring Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Daniel Vetter , David Airlie , Jani Nikula , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts() Message-ID: <20170504200928.GL24019@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , SF Markus Elfring , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Daniel Vetter , David Airlie , Jani Nikula , LKML , kernel-janitors@vger.kernel.org References: <39c8a155-cf89-1aa5-9ca6-4e9ccf3aa602@users.sourceforge.net> <56ab5065-5a24-47cf-023f-b10c6daf4799@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56ab5065-5a24-47cf-023f-b10c6daf4799@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 04, 2017 at 06:54:16PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 4 May 2017 13:20:47 +0200 > > Some strings which did not contain data format specifications should be put > into a sequence. Thus use the corresponding function "seq_puts". debugfs / seq_file is not performance critical. Familiar idiomatic code is much preferred over continually switching between seq_printf and seq_puts. And don't even start on converting seq_printf / seq_puts to seq_putc... -Chris -- Chris Wilson, Intel Open Source Technology Centre