From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756433AbdEDTMe (ORCPT <rfc822;w@1wt.eu>);
        Thu, 4 May 2017 15:12:34 -0400
Received: from mail-lf0-f66.google.com ([209.85.215.66]:34551 "EHLO
        mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756361AbdEDTMb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 4 May 2017 15:12:31 -0400
Date: Thu, 4 May 2017 22:11:23 +0300
From: Maksim Salau <maksim.salau@gmail.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Juergen Stuber <starblue@users.sourceforge.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        legousb-devel@lists.sourceforge.net, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Alfredo Rafael Vicente Boix <alviboi@gmail.com>
Subject: Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack
Message-ID: <20170504221101.094c5061@h01rn72.ncal.norcal.wdc.com>
In-Reply-To: <20170504123623.GB26032@kuha.fi.intel.com>
References: <20170425222842.60efc758@gmail.com>
        <20170425194921.29548-1-maksim.salau@gmail.com>
        <20170504123623.GB26032@kuha.fi.intel.com>
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > @@ -913,6 +929,7 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device  
> 
> Don't you need to free get_version_reply here?
> 
> >  	return retval;
> >  
> >  error:
> > +	kfree(get_version_reply);
> >  	tower_delete(dev);
> >  	return retval;
> >  }  

Thank you very much, Heikki!

I was so focused on failure cases, that missed memory leak in the case
 when all calls succeeded.

I'll prepare a patch shortly to fix this.

Regards,
Maksim.