From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools, script: Allow adding and removing fields
Date: Thu, 4 May 2017 15:26:20 -0700 [thread overview]
Message-ID: <20170504222620.GT22592@two.firstfloor.org> (raw)
In-Reply-To: <20170502064147.GB23708@krava>
On Tue, May 02, 2017 at 08:41:47AM +0200, Jiri Olsa wrote:
> On Mon, May 01, 2017 at 12:47:46PM -0700, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > With perf script it is common that we just want to add or remove a field.
> > Currently this requires figuring out the long list of default fields and
> > specifying them first, and then adding/removing the new field.
> >
> > This patch adds a new + - syntax to merely add or remove fields,
> > that allows more succint and clearer command lines
> >
> > For example to remove the comm field from PMU samples:
> >
> > Previously
> >
> > perf script -F pid,cpu,time,event,sym,ip,dso,period
> > 0 [000] 504345.383126: 1 cycles: ffffffff90060c66 native_write_msr ([kernel.kallsyms])
> >
> > with the new syntax
> >
> > perf script -F -comm
> > 0 [000] 504345.383126: 1 cycles: ffffffff90060c66 native_write_msr ([kernel.kallsyms])
>
>
> I haven't checked deeply yet, but I'm getting different pids
> with the new syntax, perhaps some mixing with tids column?
Cannot reproduce. Do you have an exact command line?
The patch shouldn't really change any columns.
-Andi
next prev parent reply other threads:[~2017-05-04 22:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 19:47 Andi Kleen
2017-05-02 6:41 ` Jiri Olsa
2017-05-04 22:26 ` Andi Kleen [this message]
2017-05-05 7:57 ` Jiri Olsa
2017-05-05 19:43 ` Andi Kleen
2017-05-07 14:08 ` Jiri Olsa
2017-05-08 16:21 Andi Kleen
2017-05-09 12:18 ` Jiri Olsa
2017-05-09 12:29 ` Andi Kleen
2017-05-09 13:45 ` Jiri Olsa
2017-05-09 14:34 ` Andi Kleen
2017-05-09 14:36 Andi Kleen
2017-05-09 17:05 ` Jiri Olsa
2017-06-02 15:48 Andi Kleen
2017-06-08 12:59 ` Milian Wolff
2017-06-09 2:52 ` Andi Kleen
2017-06-09 9:13 ` Milian Wolff
2017-06-11 19:06 ` Andi Kleen
2017-06-08 14:34 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504222620.GT22592@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome