From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752879AbdEDW6b (ORCPT ); Thu, 4 May 2017 18:58:31 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:49434 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751894AbdEDW6a (ORCPT ); Thu, 4 May 2017 18:58:30 -0400 Date: Fri, 5 May 2017 00:58:18 +0200 From: Alexandre Belloni To: Pan Bian Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] rtc: snvs: fix an incorrect check of return value Message-ID: <20170504225818.fjd47dlpdsi2fax6@piout.net> References: <1492926204-9535-1-git-send-email-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1492926204-9535-1-git-send-email-bianpan2016@163.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/04/2017 at 13:43:24 +0800, Pan Bian wrote: > Function devm_regmap_init_mmio() returns an ERR_PTR on error. However, > in function snvs_rtc_probe() its return value is checked against NULL. > This patch fixes it by checking the return value with IS_ERR(). > > Signed-off-by: Pan Bian > --- > drivers/rtc/rtc-snvs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com