From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752998AbdEDW6s (ORCPT ); Thu, 4 May 2017 18:58:48 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:49445 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752916AbdEDW6q (ORCPT ); Thu, 4 May 2017 18:58:46 -0400 Date: Fri, 5 May 2017 00:58:29 +0200 From: Alexandre Belloni To: Pan Bian Cc: Hans Ulli Kroll , Alessandro Zummo , rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pan Bian Subject: Re: [PATCH 1/1] rtc: gemini: add return value validation Message-ID: <20170504225829.2cjck4vab7d4swu5@piout.net> References: <1492951687-16777-1-git-send-email-bianpan201602@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1492951687-16777-1-git-send-email-bianpan201602@163.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/04/2017 at 20:48:07 +0800, Pan Bian wrote: > From: Pan Bian > > Function devm_ioremap() will return a NULL pointer if it fails to remap > IO address, and its return value should be validated before it is used. > However, in function gemini_rtc_probe(), its return value is not > checked. This may result in bad memory access bugs on future access, > e.g. calling the function gemini_rtc_read_time(). > > Signed-off-by: Pan Bian > --- > drivers/rtc/rtc-gemini.c | 2 ++ > 1 file changed, 2 insertions(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com