From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755147AbdEEEu0 (ORCPT ); Fri, 5 May 2017 00:50:26 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:22384 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbdEEEuZ (ORCPT ); Fri, 5 May 2017 00:50:25 -0400 Date: Fri, 5 May 2017 07:49:10 +0300 From: Dan Carpenter To: Chris Wilson , SF Markus Elfring , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Daniel Vetter , David Airlie , Jani Nikula , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 7/9] drm/i915: Combine substrings for a message in gen6_drpc_info() Message-ID: <20170505044910.rxqbv45nz4tesm5y@mwanda> References: <39c8a155-cf89-1aa5-9ca6-4e9ccf3aa602@users.sourceforge.net> <20170504201232.GM24019@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170504201232.GM24019@nuc-i3427.alporthouse.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 04, 2017 at 09:12:32PM +0100, Chris Wilson wrote: > On Thu, May 04, 2017 at 06:59:23PM +0200, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Thu, 4 May 2017 14:15:00 +0200 > > > > The script "checkpatch.pl" pointed information out like the following. > > > > WARNING: quoted string split across lines > > > > Thus fix the affected source code place. > > > > Signed-off-by: Markus Elfring > > --- > > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > > index 6f3119d40c50..dbd52ea89fb4 100644 > > --- a/drivers/gpu/drm/i915/i915_debugfs.c > > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > > @@ -1529,8 +1529,8 @@ static int gen6_drpc_info(struct seq_file *m) > > > > forcewake_count = READ_ONCE(dev_priv->uncore.fw_domain[FW_DOMAIN_ID_RENDER].wake_count); > > if (forcewake_count) { > > - seq_puts(m, "RC information inaccurate because somebody " > > - "holds a forcewake reference \n"); > > + seq_puts(m, > > + "RC information inaccurate because somebody holds a forcewake reference.\n"); > > And now you break the 80col rule. Blind adherence to checkpatch is > impossible. > -Chris No. Checkpatch allows you to go over 80 characters to avoid splitting a string. regards, dan carpenter