From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755651AbdEEGXi (ORCPT ); Fri, 5 May 2017 02:23:38 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:32899 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921AbdEEGXh (ORCPT ); Fri, 5 May 2017 02:23:37 -0400 Date: Fri, 5 May 2017 08:23:33 +0200 From: Ingo Molnar To: Nick Desaulniers Cc: jpoimboe@redhat.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v2] x86/build: require only gcc use -maccumulate-outgoing-args Message-ID: <20170505062333.hvaxghrpy5mgpksf@gmail.com> References: <20170504191409.ptpxg4ooxfqipy3z@treble> <20170505031730.6741-1-nick.desaulniers@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170505031730.6741-1-nick.desaulniers@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Nick Desaulniers wrote: > Other compilers, like clang, treat unknown compiler flags as errors. > > Signed-off-by: Nick Desaulniers > --- > arch/x86/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/Makefile b/arch/x86/Makefile > index 4430dd489620..12757a252e6b 100644 > --- a/arch/x86/Makefile > +++ b/arch/x86/Makefile > @@ -179,7 +179,7 @@ ifdef CONFIG_JUMP_LABEL > endif > > ifeq ($(ACCUMULATE_OUTGOING_ARGS), 1) > - KBUILD_CFLAGS += -maccumulate-outgoing-args > + KBUILD_CFLAGS += $(if $(filter gcc,$(cc-name)),-maccumulate-outgoing-args) > endif > > # Stackpointer is addressed different for 32 bit and 64 bit x86 The justification Josh gave for this pattern should be put into a comment and into the changelog as well. Thanks, Ingo