From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755764AbdEEHcs (ORCPT <rfc822;w@1wt.eu>);
        Fri, 5 May 2017 03:32:48 -0400
Received: from mga05.intel.com ([192.55.52.43]:51642 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751344AbdEEHcr (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 5 May 2017 03:32:47 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,291,1491289200"; 
   d="scan'208";a="82867947"
Date: Fri, 5 May 2017 10:32:40 +0300
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Maksim Salau <maksim.salau@gmail.com>
Cc: Juergen Stuber <starblue@users.sourceforge.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        legousb-devel@lists.sourceforge.net, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Alfredo Rafael Vicente Boix <alviboi@gmail.com>
Subject: Re: [PATCH] usb: misc: legousbtower: Fix memory leak
Message-ID: <20170505073240.GC26032@kuha.fi.intel.com>
References: <20170504195152.1862-1-maksim.salau@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170504195152.1862-1-maksim.salau@gmail.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Thu, May 04, 2017 at 10:51:52PM +0300, Maksim Salau wrote:
> get_version_reply is not freed if function returns with success.
> Memory leak was introduced by commit 942a48730faf149ccbf3e12ac718aee120bb3529

Pointing the commit like that is probable fine, but you should also
use "Fixes" tag:

Fixes: 942a48730faf ("usb: misc: legousbtower: Fix buffers on stack")

Please check Documentation/process/submitting-patches.rst for more
information.

> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

You are signing the patch for me which you should not be doing in this
case. More appropriate tag would be for example "Suggested-by" or
something like that. There is more information about this too in
Documentation/process/submitting-patches.rst


> Signed-off-by: Maksim Salau <maksim.salau@gmail.com>
> ---
>  drivers/usb/misc/legousbtower.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c
> index aa3c280..0782ac6 100644
> --- a/drivers/usb/misc/legousbtower.c
> +++ b/drivers/usb/misc/legousbtower.c
> @@ -926,6 +926,7 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device
>  		 USB_MAJOR, dev->minor);
>  
>  exit:
> +	kfree(get_version_reply);
>  	return retval;
>  
>  error:
> -- 
> 2.9.3


Thanks,

-- 
heikki