From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753703AbdEEWXI (ORCPT ); Fri, 5 May 2017 18:23:08 -0400 Received: from mail-sn1nam01on0071.outbound.protection.outlook.com ([104.47.32.71]:14112 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751370AbdEEWXG (ORCPT ); Fri, 5 May 2017 18:23:06 -0400 Authentication-Results: caviumnetworks.com; dkim=none (message not signed) header.d=none;caviumnetworks.com; dmarc=none action=none header.from=cavium.com; Date: Sat, 6 May 2017 00:22:50 +0200 From: Robert Richter To: Geetha sowjanya Cc: will.deacon@arm.com, robin.murphy@arm.com, lorenzo.pieralisi@arm.com, hanjun.guo@linaro.org, sudeep.holla@arm.com, iommu@lists.linux-foundation.org, jcm@redhat.com, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, sgoutham@cavium.com, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, geethasowjanya.akula@gmail.com, linu.cherian@cavium.com, Charles.Garcia-Tobin@arm.com Subject: Re: [PATCH v3 0/7] Cavium ThunderX2 SMMUv3 errata workarounds Message-ID: <20170505222250.GY16981@rric.localdomain> References: <1493986091-30521-1-git-send-email-gakula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493986091-30521-1-git-send-email-gakula@caviumnetworks.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [92.229.95.138] X-ClientProxiedBy: VI1PR0602CA0005.eurprd06.prod.outlook.com (10.175.26.143) To BL2PR07MB2338.namprd07.prod.outlook.com (10.167.101.16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b7a98d11-131b-4f25-5f28-08d494054b96 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:BL2PR07MB2338; X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2338;3:kwZQRJv42ViEXDuyTR5267AtAkC99rQGr6p8mLKFpNeJIJei5wWjGev6Y0blh7XSM4nu26v6kKHsPtmFJiBiZHRhh7801oiqGhS0NBG1hmeDh6E2YJYsBRgoqZko4UyT9DsHzNInaJs6sdZGI/D6cpntmIjQNAYIscjygINCmvzSncpHsqmwXrHPJioqIrLP0c6Pc7HgdmwD0Gyj414ZYz98vrsW+aALfd/Tz2fv8OOPfwaZwyjd6SDDLcqGNdEezsVhwWuOEzxsD9RvAEp2EbgYdaJkpqjdWB7f8M9En+TSWjUtw1JWkq1Xe75P6eXfONWDZop0a+yfd/r6DyBgow==;25:R4ll9vgVLC7+cR2H1uNrqjETYX/+KF7ShcPm/wlimBkX5czSWDDoKEUvXS7ZWCj584A1MnDa4G0jfc01jFoWWasvmC6/lY9LeIGoO1w/mlXNRd9vFQVnjtG8qd50/xrqKwU1ODiZarl9HVjxe8CmoAYTP+rlKyLu4OAnlH/pvfMGwbtNP/tXbM9nmzl0skcIFYwStyQYERdUqG3CakofkKjP87rQIaifM27j1Cw8OMZKTmKqx2F9lVumH0G5i4NI79gxZktbt+EP1zJzhFixrgdqBhtv+pd7szuWY1bFDjQRuh540TyRtu8jrX5Swjx8oBsjnkr/0c8VqMqbjHdbvm6f01YYJjc3cZ0XMxbku5VNPC+Ri0QVI6nDh/g+kgsmvX0rZyr31k4yZ8aU7UQ+WpAGYuHE9N9aeO3jxxiTJgaX4K1B11OXa91IqGdtz5BPmj3EUNkyYeNYCh0pL0qzsA== X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2338;31:qqUthpy9iGCyDSr8zwwvS2d0spgPNZNI/jVjyTUzK/XqEXy9psMmoD/FvNdDiZQfUBB+Nzy3ljIzjvwOx2QmwX7ynT9QcrhrA0X6PKVNJKrMH1sgwah7pmsl2WwUd1zsJmK/WE7YwgD2vpT/SIiP4z9NqvGPerhWQNXYreAufIpE33/AH21Qh8WBRN4z9eUqqvq2zR6RhC8JRbgKACdq3VaxZ2ffbFNSltnMX4GuwqE=;20:wrhgXH2+NOJtdSZ2aFoasGCUHFwP8cdUDzR7zA9sup7Uq/oDOQAZ9qacnWvH9wgJdAKMRBtL0TKthQ6l1rD96dXVJD358863SbFpnvKmri80p4YuXpayj5Kg4niIenXJvbNl3ltjMBkcAiAjUnED7ZKYEW3/UdJyyMxDD9aaJEHD1kO/Gmqnelt3rGxyK/kjoZUTutLiZ63QFSK+JmHg7GrynV+eTGzGAgmdAfEOLmMjsZlpaMP7IpZCk5p6GbKOTwF6XL4zp/NoJk6rK3HChWDIjG0yaiE2YfdGgwxot8oyz+TTsDctVUNDDBvetydj+VoGMQ2mP9Z33DtPbBXNgzX2+wphx5IcabRzW5PS0JdlAEkX8aS4FMJDNzOFRIMT/1i8qhE78ACQr9wKgb8i6BH6U1IHKtZxrRTAo0zVhIlN8Yvz3d0sJ90aLC6//YvRfkS8I+LiMzNgiZvokJETqO0CmZadzRCCBmtlCyo0cSsEbt3Dxsg5e0G3IMKSqU0g X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123562025)(20161123560025)(6072148);SRVR:BL2PR07MB2338;BCL:0;PCL:0;RULEID:;SRVR:BL2PR07MB2338; X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2338;4:P/OvBhzLqC/nMbmvI6Um5RcaCjGS+Zk7QCey4cguDfbq/BYQFezckLzzTpUkhUOM5nnYbdGhnO8UzhWJKNtW3RSW2FvEZkxEvJGdMJqp/sUp6EtVuhzg3TVMKkr78PqCYR7IgUgS/ptnhxB+h3xiwfy6egeXOYzOB/UCLh0KMPMGBFt25ldaVhfD5AEMB7zxg0wmrMGjr+0eKBifeC2BX9LmYMxA4aGcn1LY+qYHjZaX+lrY/yXq2Mi4uDf8NSTHt67kAMf1uIXs9Y2JX4YtuidwPPi77We8lIO19NmpUxaUdMEEMXTLc7duOSOjHYqsuRU/hV4G2GG3j19y1L2eyw2ccsoiHd5tnVE7w6S9AcHTcn+b1KY9Vz/q9VPK0Uc9kCSnDVI/NAl1R19YKeDFAj2g2w3hylsGjg8zfEpYOfw9uzRJYAZbDfk49GAYFQufKJEo/AC6Z3m1qGEg5/DeObMhw1rVgBoFDoR90KIy9ibnK7pJP7oJCY1xzNyrs22t9JTsoUO1B1KOPQOilu3dbKE8XzUB8735bolHmGOJzB22lPh1IEWYcH3Y6EF5Vv7hspdl829zLG/ZvAxtzOQ4GztzyHXoFacAFPbc55w/0gJPXgGUd+bLANr6cgA6OR66zPGHQkubdcouUGXN9Gi831bn6Vmyvy0CKvMOs2DTlgfjKfVBeLrgWE3A9FRUFQk/UPWi4ziL2PfYNjcCzvqbEl9yyHEyY+QhjJKmCJUfcCaIWqsGLufIPt9e0ce8kFStXbjGFL4Kncf0TbCRDfg2V+4V07YH4hSIbCRrd1ud+Pc= X-Forefront-PRVS: 02981BE340 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39450400003)(39840400002)(39410400002)(39850400002)(39400400002)(24454002)(6116002)(2950100002)(3846002)(23726003)(50466002)(1076002)(7736002)(25786009)(305945005)(53546009)(86362001)(6862004)(50986999)(5660300001)(54356999)(76176999)(229853002)(4001350100001)(7416002)(6666003)(189998001)(478600001)(110136004)(38730400002)(6506006)(6246003)(33656002)(66066001)(55016002)(2906002)(6306002)(9686003)(83506001)(4326008)(53936002)(42186005)(8676002)(81166006)(47776003)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2PR07MB2338;H:rric.localdomain;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR07MB2338;23:3f9B/J1jIFmVERdWz4kbOdyL9FL95BQh6z7upgIDY?= =?us-ascii?Q?Q8cz5CAbr0dPgWVdy+NsSfpVa3WdCop5XOIUbhK3Ue4Mpn90kM8Ot9QGdj+3?= =?us-ascii?Q?d8eJBe3y5/8uqHDq9cHIl8aiAjsS+v7YHzE+ZBRQODWCrU6SsnI3RtagDH5T?= =?us-ascii?Q?Cz6x8DJiFBdRF2NhNCqTcqy6G5xATwJ8H2Cr+al15zTpxl1Zpd6/Yj9pZxhH?= =?us-ascii?Q?6eBrRJ/KJTCM5xbNIlApnrXxLUZRnsRdUfThSlqvghlaa4BAGQgPAn4YhTVP?= =?us-ascii?Q?jUVxV4mvZM56mpXuPMNg+OLgaq3nUMXAGfeWUpBeykIIgf03Jt6dsYxeCvFr?= =?us-ascii?Q?tpwVjLwqYAbd7gl1122fAd6Kx0shwiuANUjvYbeDhVRvO5JUdIua3rpIK6IN?= =?us-ascii?Q?L9ruR36RvdkvG/PbcyRXgaPafFQ5s8P97LONY9ocf9U1tyDX31lan1Zx9MzL?= =?us-ascii?Q?IejfsyOyBbXs4CMnC9wCN5VqNkP/aZmgZ91euDaKLXeizVCQq90dawrCMlB7?= =?us-ascii?Q?H8HqTIXQRWizpY8TorKawJLOI0tOoQMa43dbbYXejl2fWQO416sqfw/TZYAR?= =?us-ascii?Q?qjjAgia8qqeY0R0MrpQmGDmxchQnMHa2mjx5NMvFiNS9L8Py+MEvYaTjCLbw?= =?us-ascii?Q?dP/SAWF0s5ij1gRzmQ9Mx+qAYDSxmQGkpNMxEl8qNY8KVv+pK/aD7qE8vR/C?= =?us-ascii?Q?8W6AyuYwV+JBD+drBCcOMKlWdVm4n3fPATbG6gUU7iqU9V2HfBNVyzGmhHZk?= =?us-ascii?Q?jdwnVLMv70nlaRMxFTIS8vrlEp6IgDoRFBklBtqX3dPXcvcno++nX6W3KJCp?= =?us-ascii?Q?itM3W2GJkzzj/DMFFv+B2SED0r9pbECBPmOwXwTdUnmuvj0RXBwR+NwLajbP?= =?us-ascii?Q?Fq+bWVIw3dOG69DFRQxXtWaJyQXWXd69YfIfglU/u+60I1n/MRSOFw6NUmai?= =?us-ascii?Q?p3wKS5ESSSKGgrk15STIjU7nbuG86h6Jis3lggxAAg5nvUBxFcBcCpD0SD/+?= =?us-ascii?Q?WDs8l/YhKiDIxlDbQ6ePWRg+swN9+B3ccy9FfxikwKsdzYhByZYXwgebZhDM?= =?us-ascii?Q?/8jGQpaIZH0dvui102i2+uMNwqQVTDOWyAH4bgGKjO95Xm7CP5aF745PioO6?= =?us-ascii?Q?iokIATsg60ObmwAgRj2GqiqBPPstK4rUyN/aDKvyjGXawxwOW17haGA4Wu26?= =?us-ascii?Q?uQLHuHAz2/wzaX6X5wRZEmvkCas+Ic2G9nX?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2338;6:t3sGBqGvzLpGpdcaR9c+BCaytiEEJAaDKriEvb0rxaLVFcu7pJJWDY58sZuqjpOuUE4QwnBsmcY7e9AoUIOKDvMHDi5LP0dcydFjMuhJIpY1s7hgZ1XtioSFLvCe23sjdMSdcnbzrvHCSqQCdSwk349wFg22tl8zORO9StQThcQNZbPvW2wrgtSeiydAztniJ8nF1csM60jcMIWHkw3BYXAg+hg69HmCT3cA5DFuqOJ9Re0gRkmmn5qBwADOeSFz2Ca1ICz7Fhp8TrpI12ojG5xpS/ZO7NOzhkDVgm97786KMmeEefu7lNml22nXoFU0Jc9ExPyhEvMxxxQoej3PwMah8jyoc9vB/YyXy+LnRMHMTv3F2/YQAN38IENQEa5wuIAaoL8aUVFQmfLlYx4HPzinv+74Mbu883cUxvLHJgK/siBWBcoKv6viQdXil+A1YbwklLdqzEO6fY5ek/4xuLrAwFpsl1PCZ065URREFlkFtupDzl6n5VmdCHoDYRJnYpKP80DHv8z3QT2f+2tBsg==;5:XO2MjnRe8ok9vXwgZRfVf2Jlkw129/tfieQOCp2lZFX4e3wdjf8pmSbCPhmQHJqEnRG1cHHubFoLhZ1pYoiCLcl958GcEAXDQLcVLmlSu9lqUp04eNaAzxg1m/2ACPbIf3sCqd3ykFHJP45W4SSKVQ==;24:npkdLelNVvbuouYEcVtVbJlgUWdEZHeBH1z+hcEHZFCep5dNDHKNnXyBIdarz9m1q4XITPCvz2Y3bLlATLotnAUGSG6/EnMbsDXaQJP+Hds= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2338;7:Nu/5YAvJC9ZU4ROeBF1C02ga8yNAOaLLPeuJsUdHsV26jHDeno5SNKKHHMwJtZwP3i/a5PSWXm3+ZtZMw1n0V+cIppulfZqsn00Eqxfa3JZ58pbFFMvDQoehCtXpkIBSu3cK3KukBUgiF49HPZi9nj5/oSEp9yEZ97JRSH36UwrAwraSepvY+zVJQH++oezx5FjZB0kiMQ1i6406smI/IZUigoOaOnNdVlkCIc8wlbsLwTDZ7bfRMvIgIMnGPZF+1PNV8EeXtjdP/SKAy64XHyJhsmHfKPaefWr9Uf3nrVdTrWofb7KREaREPQ0a5VWhpmF1nXcyeA7JiKxCpD5x5w== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2017 22:23:00.4525 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR07MB2338 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.05.17 17:38:04, Geetha sowjanya wrote: > From: Linu Cherian > > Cavium ThunderX2 SMMUv3 implementation has two Silicon Erratas. > 1. Errata ID #74 > SMMU register alias Page 1 is not implemented > 2. Errata ID #126 > SMMU doesnt support unique IRQ lines and also MSI for gerror, > eventq and cmdq-sync > > The following patchset does software workaround for these two erratas. > > This series is based on patchset. > https://www.spinics.net/lists/arm-kernel/msg578443.html > > Changes from v1: > Since the use of MIDR register is rejected and SMMU_IIDR is broken on this > silicon, as suggested by Will Deacon modified the patches to use ThunderX2 > SMMUv3 IORT model number to enable errata workaround. > > Changes from v2: > Updated "Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt" document with > new SMMU option used to enable errata workaround. > > Geetha Sowjanya (1): > iommu/arm-smmu-v3: Add workaround for Cavium ThunderX2 erratum #126 > > Linu Cherian (6): > iommu/arm-smmu-v3: Introduce smmu option PAGE0_REGS_ONLY for ThunderX2 > errata#74. > iommu/arm-smmu-v3: Do resource size checks based on SMMU option > PAGE0_REGS_ONLY > ACPICA: IORT: Add Cavium ThunderX2 SMMUv3 model definition. > iommu/arm-smmu-v3: For ACPI based device probing, set PAGE0_REGS_ONLY > option for ThunderX2 SMMUv3 implementations. > ACPI/IORT: Fixup SMMUv3 resource size for Cavium ThunderX2 SMMUv3 > model > arm64: Documentation: Add Cavium ThunderX2 SMMUv3 erratas This split into patches does not look reasonable to me. 1 patch only for each workaround should be sufficient. -Robert > > Documentation/arm64/silicon-errata.txt | 2 + > drivers/acpi/arm64/iort.c | 10 ++- > drivers/iommu/arm-smmu-v3.c | 122 ++++++++++++++++++++++++++------- > include/acpi/actbl2.h | 2 + > 4 files changed, 110 insertions(+), 26 deletions(-) > > -- > 1.8.3.1 >