From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752929AbdEEW1E (ORCPT ); Fri, 5 May 2017 18:27:04 -0400 Received: from mail-cys01nam02on0089.outbound.protection.outlook.com ([104.47.37.89]:1760 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751161AbdEEW1C (ORCPT ); Fri, 5 May 2017 18:27:02 -0400 Authentication-Results: caviumnetworks.com; dkim=none (message not signed) header.d=none;caviumnetworks.com; dmarc=none action=none header.from=cavium.com; Date: Sat, 6 May 2017 00:26:45 +0200 From: Robert Richter To: Geetha sowjanya Cc: will.deacon@arm.com, robin.murphy@arm.com, lorenzo.pieralisi@arm.com, hanjun.guo@linaro.org, sudeep.holla@arm.com, iommu@lists.linux-foundation.org, jcm@redhat.com, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, sgoutham@cavium.com, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, geethasowjanya.akula@gmail.com, linu.cherian@cavium.com, Charles.Garcia-Tobin@arm.com, Geetha Sowjanya Subject: Re: [PATCH v3 1/7] iommu/arm-smmu-v3: Introduce SMMU option PAGE0_REGS_ONLY for ThunderX2 errata #74 Message-ID: <20170505222645.GZ16981@rric.localdomain> References: <1493986091-30521-1-git-send-email-gakula@caviumnetworks.com> <1493986091-30521-2-git-send-email-gakula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493986091-30521-2-git-send-email-gakula@caviumnetworks.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [92.229.95.138] X-ClientProxiedBy: AM5PR0101CA0014.eurprd01.prod.exchangelabs.com (10.169.240.24) To CY1PR07MB2346.namprd07.prod.outlook.com (10.166.194.145) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 995664f2-c232-4640-e2d5-08d49405d85a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:CY1PR07MB2346; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2346;3:ZW9k2EoOrBnLJyIXnTN/4GXGC+djPBBc5kzpn3D3x3tV1GjPe2w1XKxNupXAXgBoxekX7hKznGEQSf7c0f8G7E/JgBRkAJalRV0CkpQHlkgyplYmlxpGTDNvC7sUvwv6Y1xyKupZCcqzMQVuprw3yZ9zd8l3sDKoMDy1VIuLLMZT0DrvZJsx+g9WhDxTed0FRbTFXtJAvB8TYjiaFHUdLxoQ+9eFBGjPf1GdbknXvwpiQlyRleJXaSFPzFQXg9XW6aPhSEr1cwu+LpeL+WiQJBKAIGwWpeua6f+V48sZBcBMRC81e61l2IfwxYY1o/eYHiVYIGBZfkk4ER2IuG82Ew==;25:OOprsGmFPYEV8XmJZJZIfNX0R6u3FGHfERVO5FoQGZD83t3B6VyTp4853ylupN6GR97LEs08aOV3xQav99hyppTj7Tl81s4FZKqbFK+yK8wXQZVdsNDJ27hodIfpqR7tBnQCT/lecs8qoilLqLsvE1onAlwr0f7xB1QMCIHgWykATQnTaz9XWnTYDI8E9yFtnVGOKsSVLmvxgcY0Q61F71BFBvn7XivtwDM8xqs2JoI8CksumtVfTTmc/pSl1h/Qx5r1tx7P8C97r62WRqnVepvKCls88KCaYNmFkA82s7Q0c6Ejf0BxtF31VRGU1D83CpewW0MM2fkczb/urwLgbHd+lG9U/J5Cf7RWvb61nU6U4/HUySePac2YUGueU2ELZey2Xjv9Ai1HCfUW1u9d/bOwOvRvWRIw0eopRHRlw95s9BTAGPhWD1ANCGMnZJF+UA27jOe2mSwZvOvkxm8lXw== X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2346;31:+llJC4+cx9HfOCFEEhn0Bd46hD+wvkLRwPs35BlRrKE7Wl9zqKb6qcCEu5tVaKxT9whhzkzYxnap6kl0Cdso/MosCe/9qjJaUR4mwfMMAojWhwNQ42E7oxd9HdG9aN8B0aYZKEExG8559Xd4IsQpkE5VwvTPzML4jnG+5nLb3nPXusm8GpQ93NDVC8MGKPOl+uiAVrtK5Dnt8xPVugidj/roo23p2Txpn+QaCMW01QEyHkYdZ7tfhMDGSW4rRbOl;20:azH/tFoEE+5vbqJxiHO6qCMhtjo7zfvecGaibwXiS3sojUN+ZHgbcqUptqQjdqFu6IXO0Jq47DdpjjzXPY7yjobotdlPiG9ulYoXuezfdpKOsvu8HLKei9NGl6mQa1y2XJMwBxKPgtay/jCtvXY1jx7fmHmrQTl3wHyBew2XR7zcNp0yY4P0aEUKjEmJwMRA0AWBI36WM3WqPqlB9m0KVvfAuXn1DqSsNYRV4MNm6mV8Vsd5KuJ4JbIHwipZHZotFE1Y6A7f3RTzi+5ovSNuZHq1yrt6pmgOfNHF5tcaO/qmcorJkz+mTAkksM9YRnzJh3efueQuiYb1jp8FWeCA2n+dzxuTIHufdBBRvJEFLPNdaizyjGzza6UNrW3JfTpI474g1rbGVyT0Kahg+b1LRpGmMI4bsiPP2mWpkV8NH3Z9+d7w2/eLN/yPbux7gj5nNayLwUH1GVOyAUabGebdg82J9n/nidCDuFvfFt1CfYSe6oqYZagjCNqxia1n13Ww X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(6041248)(20161123564025)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148);SRVR:CY1PR07MB2346;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2346; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2346;4:XnD0QqX5t0EH5ONLbbqQ1tnbzv+neaZ4PsYDb32qluh7R1HyIlItan3xkh6ogY47cz/3NgwYqqEGFY0ECWEMdQ7Vo+/pgPfV4I12CmADos3faM7N9/Iyu1UQH3iZ0WCkk/86urdIbtenV6d/oO8n6edEPzimCZTaHdQxu6gZoumQkVWWNfxAkzBiHo65pJ/WyBq5oEiR9quzyhlv/aYmr9mw1ru52g2ikE08sZxBXtsYQenBCQbM8L9FrjmGFTJ9LicBjR1I6YldH6vNdkH/eCyA5iCEEGOCWo9rqThbd3ER3IoNtOWsQnQfpFt2O2fkcrzWqOIOrIhRe0XO2Kft9oGqvjiwlwoZyyDWl820afBNg7zRcsLZkFWqko/VTEYP/LgE6ky8m8uSIZZknikJiKmdcrcfhn26hOFRFXa0Yffwc/Cijqes1ZL6pmbq93DcpY6Ckk8WHTtpRDmCFbtD7hPmUjzh01U+zNN7Y7YCEnu1MDlGnhJ4nhE4OZZnlXsXFKP7IWyQwIp/mVYktv9zkEy61dYMbHCAXF6hB+6Q7ndllChako8OScEMuUMKnzX6jf+YUhPa77+oHWc39yUPXzfKeVuqqrZexyOqslgAyVUaX9fqGsodhw6S1w2WmKPcbEZEj+PO+3cnNZ85B/7lqjH9HQL5bWTFg6UnHAmYS5u14bcUYJtQ3YI7J7Gx89HL9J5+ANZN+w4EsTeX2dSr9EpDFAK639CifJsGds2lpBiNwIjljjUVZWbXaGFnPOLJ88wl2cAoPuApq4qQH0k1QM0W2uWil3CCwsKfR34eKGo= X-Forefront-PRVS: 02981BE340 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39850400002)(39410400002)(39840400002)(39400400002)(39450400003)(24454002)(1076002)(23726003)(6116002)(3846002)(189998001)(305945005)(7736002)(5660300001)(230783001)(6862004)(47776003)(83506001)(229853002)(2906002)(33656002)(4001350100001)(50466002)(7416002)(2950100002)(66066001)(6666003)(6506006)(53936002)(55016002)(54356999)(76176999)(50986999)(25786009)(53546009)(478600001)(6246003)(110136004)(81166006)(8676002)(38730400002)(107886003)(86362001)(9686003)(4326008)(42186005)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2346;H:rric.localdomain;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR07MB2346;23:ozt+25BlYdWkaErTyGvTEhaAtkqQx4iZ3U2I33EUz?= =?us-ascii?Q?ywEs776Gl9Tp4z5eQ1a2J2+bxsrmmhrpdS9BROOyplpIzq/rdxFW36PudI2D?= =?us-ascii?Q?QMiKvEpYUQDdO2hxxtJT145pZAUMd7nFrddlGGfeCSOCbtYkREhfMGnmyw/Q?= =?us-ascii?Q?41dmV8fQPSvDxCPkIMn60nDNBvAahNaEChddEnrGnpyfdDC+BQ/22IyOw8WS?= =?us-ascii?Q?MZXfYNOyGnNuZzPikfV0DjV8htabJtVh08123t3BduwQnbcJsidBXgIZ9TLX?= =?us-ascii?Q?GAUELQlzzFUS1s25IQC9esKlYG9KI0a+wbC2T+cvk5qOeRECcvxNY4fFAnsl?= =?us-ascii?Q?wd2bL+FxsEOBDGREeISsEtzEkJckpUYWXNJ9NRla6J6WlUVCDw1s4qlrNnqv?= =?us-ascii?Q?4HQmhTCsb4wc7Ag/lLblmQI4kSk5maWtd9vwhcIGp72IuEh2I2EYg9SRMAke?= =?us-ascii?Q?R68X57CQHLMnvsXo8/PPV98GPued9md3h5607+jxTS+yeJ4uguHzQ529iM+R?= =?us-ascii?Q?zNm27t8eQMLkOQRgO+OwBj4N4gu75wG46BSNJQDkBLDTDd3crkQGK1SzFk1o?= =?us-ascii?Q?bJnSBo9pFq6AdmEdJfbFLjhwtxs0nsREJre7lOZpgQIVJvCbWpMTrT2OgHYK?= =?us-ascii?Q?cAhddOb5rAVWX9TwD23S5h6GFceoHf/nuI0+t3etjSBHV8KZ7nbNWfpMJF5z?= =?us-ascii?Q?nSc4BEb2nUljy+9Q8mLiQYWgTFRr8eo3Qj9x7qAnQWJDMDhCwKtx1gLQFHA6?= =?us-ascii?Q?tSIpoorSn5x2071vmWqTIe7amHeHrSaNXFLZeDFCakjyFTtjjqU2MCWV3bEm?= =?us-ascii?Q?f641OULysaJCzFtJIxd3lIdboQEgL3yS24i3TpOikmydZEU05jhRxUc2NNCf?= =?us-ascii?Q?C5YOFfEB1UOySFyrMu24TqDn0yLoOk0j+/r6AxxJGG4sKAQ8f3hs+8F81XM1?= =?us-ascii?Q?htcAVLfH5TffOGtkqhnQfzDz7AzxQY4QcJMf6rl0BHVhYFtRwzONeCrT5DUO?= =?us-ascii?Q?+tgZ0jxzjy/k7lHPfA3AKtzWKCbdd2umEwkkVxpIaaNTK5K3vwbTdEljYGYI?= =?us-ascii?Q?xuR7PUS2AuU7XhPI9k55voD0eCq6x+IX6f2DSde/SMj0OLzI16hZ0ja45ugm?= =?us-ascii?Q?Pm12usMcQ+70afj1SiUlGeFoNWkgm96LX9HhpDXT7P7lyrL87eoDJYhrvhgt?= =?us-ascii?Q?2CoPolElRrXoORPUfMvqhmIViyolM3s6pzNxid4v1/2KM0PU6y9ztFN5w=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2346;6:Rp8DsNdpOjshbftSkAoJ0GNWEZfrjasRa17ED+xSx5bCoPKBLUa4Lr1/ZyqYypSVZJVtTURHiC6ACql015XEm+VMKTetv6qZBY1w9FJObrm2+i/Cw3SKFv0yNmP5SiqgulkISOKrl2QVskS/kE5QO3NkRhJsQr/BH75QFlLZtUkGhHut+SuI3G5c4g/ClTYAonuJb5NDNd5gjPPldj3d2AoYrGowaK/Cg5eZ7qHZQCd6R15cXz2BINV45fWSe2yNXsNs6BMa8yYE8Up1d6hioJ6fTREfuNZip9HgUY+o0YEtgj2sWcFlS2XYhHY/6kHGB1S7D0mfN3ah9hvHRVxVI+t9hLKO+ZV6Ao+34CJ3IPA0uRXjccJ1R3JFcmpm54krghB6NrHOBM+z6QaERdjlMj2BCb24HKzKYLabxU2zmHrqV/VkpqpAAmBTrAQBW125DSk5LqJfnxNq6Qy8Vuddpc/JmNuYH5eQGlQPuF/27+V39mq6+fy/JnuUKCtq8pdI4P1J0quNSohd66jqsiYddQ==;5:Gd3c64P2TViHILO3gVj7t1SftPlxVPGj/DhZc5/sd/DROsQAg/bsRIR+qwi3Uea9/SgB1BIrQPkFOegLyL6V7tm9NT2R4LruKKShohzS8OF/Gl4KljF6X9eAQTKCwg+yYiy+EtSG2SIynng1kXQu8w==;24:bKocgcA6Ug0yBkVWPMfbQy2taoQa0hllwUMVsTQtbRsxoEbxZISfvYv+6vzZaYLqvUmtrT6kK4yaoJiW398flSefDJNZ5FoErW554k8ciEc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2346;7:HC+W2l33TFAPN6k91ypjNI+76axCfl9UJetAMeZ7Xiv2tg/xXojVVVw9v5XEca/z6uFZs0YFKpmPzyboX1krW7EXWC5s0YvNPhv+NQ9dYZjKUXd/U62akiUWwmQA5+HXHs5veQ/KmIK7dvkPG313FgkdCUr/l2NyuQYGmuZlU+MHe3HlV6vqMdP9owwCLKg+JBzYCScGhEBKnOEf79Un7zc75FJPFRYoE/5a8nLrGRAYvdgn0dNcas/jOaDVt5RnkED6t5t7TJ59PuR0TUyW+BhikrtyL8aczzJsuoSd026R4NsZvRNlTElnvwn5ku1+Keo0wGnaCjRClVZ/wML8jg== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2017 22:26:56.0249 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2346 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.05.17 17:38:05, Geetha sowjanya wrote: > From: Linu Cherian > > Cavium ThunderX2 SMMU implementation doesn't support page 1 register space > and PAGE0_REGS_ONLY option will be enabled as an errata workaround. > > This option when turned on, replaces all page 1 offsets used for > EVTQ_PROD/CONS, PRIQ_PROD/CONS register access with page 0 offsets. > > Signed-off-by: Linu Cherian > Signed-off-by: Geetha Sowjanya > --- > .../devicetree/bindings/iommu/arm,smmu-v3.txt | 6 +++ > drivers/iommu/arm-smmu-v3.c | 44 ++++++++++++++++------ > 2 files changed, 38 insertions(+), 12 deletions(-) > @@ -412,6 +412,9 @@ > #define MSI_IOVA_BASE 0x8000000 > #define MSI_IOVA_LENGTH 0x100000 > > +#define ARM_SMMU_PAGE0_REGS_ONLY(smmu) \ > + ((smmu)->options & ARM_SMMU_OPT_PAGE0_REGS_ONLY) Why hide the check behind this macro? Maybe make ARM_SMMU_OPT_PAGE0_REGS_ONLY shorter a bit instead? -Robert