mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	thierry.escande@collabora.com, wnhuang@google.com,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] firmware: Google VPD: Fix memory allocation error handling
Date: Sat, 6 May 2017 11:40:04 +0300	[thread overview]
Message-ID: <20170506084004.awyhl2w2b2qnbvt2@mwanda> (raw)
In-Reply-To: <20170505195647.GB7351@kroah.com>

On Fri, May 05, 2017 at 12:56:47PM -0700, Greg KH wrote:
> On Fri, May 05, 2017 at 09:08:44PM +0200, Christophe JAILLET wrote:
> > This patch fixes several issues:
> >    - if the 1st 'kzalloc' fails, we dereference a NULL pointer
> >    - if the 2nd 'kzalloc' fails, there is a memory leak
> >    - if 'sysfs_create_bin_file' fails there is also a memory leak
> 
> Then it should be multiple patches, not fixing 3 things in one patch,
> right?
> 

I agree with Christophe that this is basically one thing.  Otherwise you
end up breaking it up how Elfring does it into tiny tiny snippets that I
can't read.  Doing it this way is easier to review for me.

regards,
dan carpenter

      parent reply	other threads:[~2017-05-06  8:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-05 19:08 Christophe JAILLET
2017-05-05 19:56 ` Greg KH
2017-05-06  5:02   ` Christophe JAILLET
2017-05-06  8:40   ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170506084004.awyhl2w2b2qnbvt2@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thierry.escande@collabora.com \
    --cc=wnhuang@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®