From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932131AbdEGWDH (ORCPT <rfc822;w@1wt.eu>);
        Sun, 7 May 2017 18:03:07 -0400
Received: from mga02.intel.com ([134.134.136.20]:14997 "EHLO mga02.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753923AbdEGWDF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 7 May 2017 18:03:05 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,305,1491289200"; 
   d="scan'208";a="1165789566"
Date: Sun, 7 May 2017 08:29:17 -0700
From: Andi Kleen <ak@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>, acme@kernel.org, jolsa@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf, tools: Support srccode output
Message-ID: <20170507152917.GG27157@tassilo.jf.intel.com>
References: <20170505230029.23826-1-andi@firstfloor.org>
 <20170507144538.GA12933@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170507144538.GA12933@krava>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> so get_srcline formats srcline and you parse it out back in here,
> I think it'd be better to factor __get_srcline and get the file
> and line directly

It's not true for the addr2line fallback which gets the already formatted 
string. So at some point it would need to be parsed.

But ok I can move it into the low level function. It just makes the patch
more complicated.

-Andi