From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751230AbdEHPgn (ORCPT ); Mon, 8 May 2017 11:36:43 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:57626 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbdEHPgm (ORCPT ); Mon, 8 May 2017 11:36:42 -0400 Date: Mon, 08 May 2017 11:36:37 -0400 (EDT) Message-Id: <20170508.113637.783558334411383400.davem@davemloft.net> To: garsilva@embeddedor.com Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, joe@perches.com Subject: Re: [PATCH] net: ipv4: add code comment for clarification From: David Miller In-Reply-To: <20170504194415.GA29391@embeddedgus> References: <20170504142432.Horde.g9y26Ryxbtg1EIl_cnsdbbw@gator4166.hostgator.com> <20170504194415.GA29391@embeddedgus> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 08 May 2017 07:55:13 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Date: Thu, 4 May 2017 14:44:16 -0500 > @@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk, struct sk_buff *skb, > nlmsg_flags, unlh, net_admin); > } > > +/* > + * Ignore the position of the arguments req->id.idiag_dport and > + * req->id.idiag_sport in both calls to inet_lookup() and inet6_lookup() > + * functions, once this is a locked in behavior exposed to user space. > + * Changing this will break things for people. > + */ This is implicit for every interface exposed to userspace. Therefore, saying it here and there in various comments provides questionable value. And in fact I think these arguments are probably in the correct order. I'm definitely not applying a patch like this, sorry.