From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752711AbdEHVdh (ORCPT ); Mon, 8 May 2017 17:33:37 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:41478 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751498AbdEHVdf (ORCPT ); Mon, 8 May 2017 17:33:35 -0400 Date: Mon, 08 May 2017 17:33:33 -0400 (EDT) Message-Id: <20170508.173333.1140782402828347971.davem@davemloft.net> To: grygorii.strashko@ti.com Cc: netdev@vger.kernel.org, nsekhar@ti.com, ivan.khoronzhuk@linaro.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, spatton@ti.com Subject: Re: [PATCH] net: ethernet: ti: cpsw: adjust cpsw fifos depth for fullduplex flow control From: David Miller In-Reply-To: <20170508192121.20451-1-grygorii.strashko@ti.com> References: <20170508192121.20451-1-grygorii.strashko@ti.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 08 May 2017 13:52:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grygorii Strashko Date: Mon, 8 May 2017 14:21:21 -0500 > When users set flow control using ethtool the bits are set properly in the > CPGMAC_SL MACCONTROL register, but the FIFO depth in the respective Port n > Maximum FIFO Blocks (Pn_MAX_BLKS) registers remains set to the minimum size > reset value. When receive flow control is enabled on a port, the port's > associated FIFO block allocation must be adjusted. The port RX allocation > must increase to accommodate the flow control runout. The TRM recommends > numbers of 5 or 6. > > Hence, apply required Port FIFO configuration to > Pn_MAX_BLKS.Pn_TX_MAX_BLKS=0xF and Pn_MAX_BLKS.Pn_RX_MAX_BLKS=0x5 during > interface initialization. > > Cc: Schuyler Patton > Signed-off-by: Grygorii Strashko Applied.