From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752031AbdEHWAL (ORCPT ); Mon, 8 May 2017 18:00:11 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:42460 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580AbdEHWAJ (ORCPT ); Mon, 8 May 2017 18:00:09 -0400 Date: Mon, 08 May 2017 18:00:07 -0400 (EDT) Message-Id: <20170508.180007.626860706220120048.davem@davemloft.net> To: jon.mason@broadcom.com Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error path From: David Miller In-Reply-To: <1494280115-9252-1-git-send-email-jon.mason@broadcom.com> References: <1494280115-9252-1-git-send-email-jon.mason@broadcom.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 08 May 2017 14:18:40 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jon Mason Date: Mon, 8 May 2017 17:48:35 -0400 > If an error is encountered in mdio_mux_init(), the error path will call > mdiobus_free(). Since mdiobus_register() has been called prior to > mdio_mux_init(), the bus->state will not be MDIOBUS_UNREGISTERED. This > causes a BUG_ON() in mdiobus_free(). To correct this issue, add an > error path for mdio_mux_init() which calls mdiobus_unregister() prior to > mdiobus_free(). > > Signed-off-by: Jon Mason > Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs") Applied and queued up for -stable.