From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753466AbdEHD0x (ORCPT ); Sun, 7 May 2017 23:26:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40436 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752972AbdEHD0w (ORCPT ); Sun, 7 May 2017 23:26:52 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A942E3DBE5 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jpoimboe@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A942E3DBE5 Date: Sun, 7 May 2017 22:26:50 -0500 From: Josh Poimboeuf To: Nick Desaulniers Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v3] x86/build: don't add -maccumulate-outgoing-args w/o compiler support Message-ID: <20170508032650.lefwzesoyv2pzbsz@treble> References: <20170505130552.m2x5bjgexlktxsyz@treble> <20170506030509.4435-1-nick.desaulniers@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170506030509.4435-1-nick.desaulniers@gmail.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 08 May 2017 03:26:51 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 05, 2017 at 08:05:09PM -0700, Nick Desaulniers wrote: > Clang does not support this machine dependent option. > > Older versions of GCC (pre 3.0) may not support this option, added in > 2000, but it's unlikely they can still compile the kernel. > > Signed-off-by: Nick Desaulniers > --- > arch/x86/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/Makefile b/arch/x86/Makefile > index 4430dd489620..5a0ac8411792 100644 > --- a/arch/x86/Makefile > +++ b/arch/x86/Makefile > @@ -179,7 +179,7 @@ ifdef CONFIG_JUMP_LABEL > endif > > ifeq ($(ACCUMULATE_OUTGOING_ARGS), 1) > - KBUILD_CFLAGS += -maccumulate-outgoing-args > + KBUILD_CFLAGS += $(call cc-option,-maccumulate-outgoing-args,) > endif > > # Stackpointer is addressed different for 32 bit and 64 bit x86 It would be useful to add a comment in the Makefile above the KBUILD_CFLAGS line stating that clang doesn't support this flag. -- Josh