From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753874AbdEHKE7 (ORCPT ); Mon, 8 May 2017 06:04:59 -0400 Received: from mail-by2nam01on0053.outbound.protection.outlook.com ([104.47.34.53]:28833 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752759AbdEHKE5 (ORCPT ); Mon, 8 May 2017 06:04:57 -0400 Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=cavium.com; Date: Mon, 8 May 2017 12:04:43 +0200 From: Robert Richter To: Robin Murphy Cc: Linu Cherian , Robert Richter , Geetha sowjanya , will.deacon@arm.com, lorenzo.pieralisi@arm.com, hanjun.guo@linaro.org, sudeep.holla@arm.com, iommu@lists.linux-foundation.org, jcm@redhat.com, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, sgoutham@cavium.com, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, geethasowjanya.akula@gmail.com, Charles.Garcia-Tobin@arm.com, Geetha Sowjanya Subject: Re: [PATCH v3 1/7] iommu/arm-smmu-v3: Introduce SMMU option PAGE0_REGS_ONLY for ThunderX2 errata #74 Message-ID: <20170508100443.GG16981@rric.localdomain> References: <1493986091-30521-1-git-send-email-gakula@caviumnetworks.com> <1493986091-30521-2-git-send-email-gakula@caviumnetworks.com> <20170505230328.GN4906@rric.localdomain> <20170508091739.GA26003@virtx40> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [92.224.62.136] X-ClientProxiedBy: DB6P191CA0002.EURP191.PROD.OUTLOOK.COM (10.175.236.140) To SN1PR07MB2352.namprd07.prod.outlook.com (10.169.127.18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0e4f5442-12ce-4d73-68f6-08d495f9acd6 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:SN1PR07MB2352; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2352;3:oK/30e9E4j018rkxcnecVfYklqE8cV3bkPu9sBkC2s/McedovPKY6vSCfto5wv5BtWLlu+NuzFJk1c6YhodU5qOpcp2Eb5L914hPxyv+kc5ZhtaA9isgVNyOqc60Vt6rbzYx5sI64PXbztoFbbya9Qs7nGTruHpRWjsH/A+9bEB/OhKaNY+hhCXvFuz81qgxSofNAT6cFbrY9qMIigoYg6E3hAF9v4vCWQk5v1QEDqqqDSzdAKybfavMKF6ucAcZyPfkw8pzT0MGVx3bojKs2KSwnDJ/+ZtfpxMMIkXA6hE3UUbxSMvXzNabIvFFu5ZJc5YDi8pBSAimWiB8aSmwmA==;25:093CsUsjKoaX2LghQQG3JOhx34JhdnIPSNtOYFNbt1x2m+t1bpYy5l90SHIsv96H0VtBaLsm50Hbf2s4NMd26+KDUq96ofIBQqc4KLoEDXFvhwXy5S8RPA7DQIWicw71bj7Vrm/Pa1cgFwE2qpZG5oNg5eWBcNcIex+bXbWIQUU9CrpQn172rk4LVWMOAkVNyDtkcCLxE0fJWdgTM3oSIdFi3pUg2WS8aXEtbHYS5VP6noa9LftWDUpyuuW4evn6IUNSGGvlZokM6r3AQxRBhWcimfK+1PhFGoxP/fXKkDZAPHRmRl4pzEcYWerW2fUFUU8RtfliovO5a2Yj4wINl5oytwS6oeQugBbrb9T9bYmOtY4BhR0rJOdtzDL8glz4OD4OxhycjgFruNmQPX9PIRdIDgdkBgPcSO/O3jd6e6F9N78ozD17tzaTitwZsfppY5ZSokOdYjK0fr+cDCYCbOnh6YaFv6aSVScNMiMBWKc= X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2352;31:JK2sZ30cq+ZYjynCoBpGUI049hZHJn9Fx0usOu06kQQHlnBQ0kCVZXSj842IxK2lVpQCjL/IozNIgNW99gIq6OYIQm9NgYQI94ws50n92S4gYHiMmF6mN7tgNhLCwqXNYkOQ5YkIBs/NvSuRIbB4A0gSrscq2OK+UQUnTQ3JbCygcgHv1DkQMtWNw/bWLiVYnDq7dJfZnnf5tlNSQZssJpXB3ljAro+xW3FMyO/tTes=;20:ET62L/q1+lJsRsyC5/qSl+7Oh5zM8mmjXnwAStrV9rZV6t7wVy/fICJB+5BL0f5xTjR2sfRPtMARZiT2hHmCvqcfUsSeBuArOnRa0LbCxO2FOBt6Mtv4Hi/GMu8RI/jvxfoE566uH9rzOdszQ3zy/LDxQOYtbKL7kquZUBAt4ZzCIbM1uxjMzXaJW5xPe94DbucDFDCNc8mSSsw0lXfZr498n0prkYvXuwcdX2cJZEoVi1biMsigpeaMPMqGikBOi+uzUS89qQK4vdh7Qgj8vtjEfMXzh/x0MCcLx/+rLcdGeMCq+UOcb27oeU54w0vvgvLhzwdrDBjvSv8ryGfylb7T1dL+rle/Yy+D3NzjHdLnkUq6Hy9dkrB/Au6slv5jlkZwBFZKlPHeV4uzqe8pqA3GZ6IzP2ONzm4dcP6XkMAvYyglo8exwqOM52LgcqsV194xuyksIROQBtDAZ+CgTjBnqKkmyvhGL4R6tZmk3NmPePxbXT25RNW5MUgA9iq4 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(20161123558100)(6072148);SRVR:SN1PR07MB2352;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2352; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2352;4:J305a8Z9j6ra1oWuSJtvytr1YL/o0v15cYHRztRQoSoawwdWj53/Cj9yH4wERpeY+MG/a7aSJdOz4+POYvlVOAdSYzHl3Z5c8zNyEdhbNXDsUsRSKk93+pUFpD5eRTNTekbL1EfC8QmFBSTsclYfCp90LCZkoy3U/rIFL3Etz8O/n7kDL+I3glPROtbAk39rucuVu6OvK+C+o31ee/M97jkapJYC7iW89IXAM7GjrB5jINy6F2SojA4aZXeFP5eV52NVNSQW+bFSUjIYiPbwkeGDJfkj2d07jU2DvDwHYWUF04GY4f6hoxCrHReLOyU6PYTYCq9zOb9CXnAPFEiZFcxRLmjT+SrLGhxDbyM+Wf0vLyN3XVv+LBLZFa+LM4rYwncuAm+yqHisd6Og7+isQlbmIqDXrrn5DovDKvM50K7GhGoTtOE+yuWkaW5TWZWk5zJrc90ScQiVTpS3Os1QD+UCNtujtmQmJl0pQqOoh8c9LvESk8eupT7vT1rYi5jFxZ+FRz6mf1mhbgaGdbf/hBidUxCf8o0cPiiU4P8BcidbfflW9q/hJxMT4PyE+ZRL/T3E+gCMNoI49nyIBSfhkrtKMKg9FTHsGSljZEOsXQ1Pd7T8HgCPKXR8G3X9i050BpC8N05LtMW1gyxk5+zZKPWHwYaZyURQXsPzIOIf6BRTjJ2A4Gwj7x8M5EmghzxyR3NL+rAJxyB+oDx3+1QALjFo9HrI8b/HgQCPLssw+dI9SnesiCcHIq/J0pbI1Q3TaQ/DT9XDF1ABhs+pP57RR7g1nhktwWxmJ3SqjDFCNrM= X-Forefront-PRVS: 0301360BF5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39400400002)(39450400003)(39840400002)(39410400002)(24454002)(1076002)(6246003)(6666003)(47776003)(3846002)(6116002)(23726003)(66066001)(25786009)(230783001)(2950100002)(83506001)(93886004)(53546009)(4326008)(38730400002)(107886003)(2906002)(110136004)(6916009)(229853002)(76176999)(9686003)(33656002)(5660300001)(53936002)(6506006)(478600001)(42186005)(7416002)(86362001)(7736002)(4001350100001)(305945005)(189998001)(50466002)(8676002)(54356999)(50986999)(55016002)(81166006)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR07MB2352;H:rric.localdomain;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR07MB2352;23:x+DjtqewlLMc9hzSHS3omsW6iWBnbnQt4jvyAbLpx?= =?us-ascii?Q?o8cYG62bjIGjrk2m7ZQCvkH5OaifD5WWJEEHmclMprbi5IkXF1ng2K4IvY4j?= =?us-ascii?Q?cYBEkNOgAXEfcxC8KO5puY7N8ICFLqJtDjgG9BaBwmnwuQ6XMxchFOIKsiv5?= =?us-ascii?Q?dHF6gjzIr/sbRBti+kW9bYaxFl/jUnF8nei0wYcOY1u341THosOvg45thOyP?= =?us-ascii?Q?0BigyGlFb/QgEFh3CCFAuMbLdM8pmLHAtCycjqNi0ONj7Il5otOfIBR7aFLW?= =?us-ascii?Q?bQwfhohYVrUVjWbtgBBGJiM/X0Ym0J0bMTOZ+xMzWxb0Ns9P/WNdiwOPWl2T?= =?us-ascii?Q?kFCulJ8dr6Fbh9isnJXcj+zF1qgsbmdNWMRs1wTXmjYHM34Pl0Dn/y6z1/Ji?= =?us-ascii?Q?OB8MN2qE6SaRKO+R9Kh62/i+QczbOup/fSB7Er4DiWPBjvlLJzfNUkdl4uuh?= =?us-ascii?Q?ILPVDi4MSHjWd2k59gougXS2k7XdDsB+josxB2/0CFwbnMU5mKXnMr3Kk+6E?= =?us-ascii?Q?jX6pQv6pPi6IDxiUi2G9nd0Iro6XpIX4D/s1PauBs6Ae2ijc7OneOKRQ5KSf?= =?us-ascii?Q?zf6+j2x5YGPS2sQz4QLMi99OQk3XFeImirlumPSSDvF9PnzNhwfBLzUWmlbL?= =?us-ascii?Q?aVtT2tLFg+r/ivJlZUcg2riLgjT8EG64TRLOtOQdeIvndkZf4m3x0zS/ERps?= =?us-ascii?Q?0mgvji8PjytywuQIelv8PcrEi5ft7AlpamLrPPoJm0jnkQ8l6Y/b4c8MUANg?= =?us-ascii?Q?4dknHJzTgpaBFMdMJuYu+V62U/dPF7JPQQSULHSxW352od6A9l/nZObcDZxQ?= =?us-ascii?Q?ElDG2tEWAJKsfEvVjO9k0tN/unHNZCvtwjsZk7fsN84Al6/RwuT5CpjV6gpg?= =?us-ascii?Q?qJeOFf756ctQteTRLsom7Yl+11G1ar2u2kLMw+Ymmr0w3m3upliaCOCosc4R?= =?us-ascii?Q?LvXCl8lWjz98enRhiShHx+LRZJxgiNIjeHMLhnCmstWBLQikZHHLZm6ni9qd?= =?us-ascii?Q?FZvywlY/jO7yO2nCSLIJqbxx5PyMrE3phnxcoZK/r1GoWTKQf+LhY5AuCUNi?= =?us-ascii?Q?JUzVO2ej3thnsZu2ZXU4t/nd8y1f/w66G2W6LYeZxsIHAqA09HBbMR+B9iyY?= =?us-ascii?Q?XvxIvegDAm07PzdNI3StakEA5JPaNmZgxwIpBrrR7aMyuQSS5P8W/HjLTQjt?= =?us-ascii?Q?rTJTz7ibIR3c99LkBEWQoG+/IkRp23o+9mf?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2352;6:hDQ0NqC7k/1WTn1iKOPUmSBMR3aUm6FoXmzFsAJcy9yPQZ0o8d4RiHoi69TN5pxXDyKEY2YTXxkm1drLi4XVtGHboEeNYHtd88VGculCjakY19yUhA/3ASuGwJ8uYjvpMbpOuzCdR3Gj8y8qSdH28EihaJPUoe2EnUPzu6yWq6jbMIN8HdHmrLD0ikhSbzbhvRsSxHXhgVTzZSYb7e81EY8InnEc7+szPlOk4xAVcWOYiA0ZlgdCxBNHspar16gUDDcX1BPv3f/4yvkJKrg0JKc9eV96MKFrRcCb8HXH4r+7Yd3LIkINw8AN6akb3HkPtruvu7qV33wS+1IDMYXp5l0E+k5wqDtyTaloOIN1pWDg2z5Cipbm6nj+Zd2UzEWqo8d1ZVwEZd0cJBhTADpuZi5+yVr4Tl1VqfXCo04jmsta3NLA+c9VitEMeKlNYoDHc5mO0WT5ojRhpock+c7WRzxSIYXWE12v98kpjpStTcD41xDiCjF5hZwvdXeabuurWT+VlRrBYvCAQyvj+mo2JQ==;5:/c7WARI3HipOQ77m59Y1GTIjA7ypbjC5ZcvWq+kfO/1XqOQZpk+TfnVWQAccO90kvd7vWp1dHauvCAXOhgHiZ2X0HP7zW7Occ6Q5bnpgzDN2pUeFzG6OISFADSePjwmBUIMelBL94lCuhB0HVEBZAA==;24:p4uRnAU8d6CzCy/7LHWIdxKKHAyhpNeo8ByOviBKiChw+S/GE28mHJ9jjnYLqjuexAOVJ0fSYGpMs4+Bn824y5j80eYn/LGRLAk32jhx5gI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2352;7:du5kLqGHF1EaSOFJoc6UFGuOxzsWm7HQG1iRI1YupQ3Bk8NogtxQq5MH+N4gfWWV2Fq5+spHDFpjd6/IoTybcJMHfq3Do/GwwuI5OKGF84COlz+71XcwlvTPcH2gXqb6UReGZ7il2CjIqNrFsARh0HfaeiRmgG+biHkvl4DLGNDRo4HIzA9sXjv/HSWzdU3HDZZd1UG9+bS5LaIFXnnIEuk5XeclKX9J226LaYHgOw9NTaKeJNy1Z2azXZF2snypzf0Hy25iDscZ9QKLsJ4E7xHe/+7hLS/S6uDGjJxxKzFbLH89xKdVcZb+X6xtYTffmFQ/irPjtPNvdsGuhCUE/A== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2017 10:04:51.0209 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB2352 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.05.17 10:59:46, Robin Murphy wrote: > On 08/05/17 10:17, Linu Cherian wrote: > > This actually results in more lines of changes. If you think the below > > approach is still better, will post a V4 of this series with this change. > > Why not just do this?: > > static inline unsigned long page1_offset_adjust( > unsigned long off, struct arm_smmu_device *smmu) > { > if (off > SZ_64K && ARM_SMMU_PAGE0_REGS_ONLY(smmu)) > return (off - SZ_64K); > > return off; > } > > AFAICS that should be the least disruptive way to go about it. Yeah, let's go with this. Thanks Robin, -Robert