From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755547AbdEHPUO (ORCPT ); Mon, 8 May 2017 11:20:14 -0400 Received: from mail.kernel.org ([198.145.29.136]:47202 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754771AbdEHPUN (ORCPT ); Mon, 8 May 2017 11:20:13 -0400 Date: Tue, 9 May 2017 00:19:57 +0900 From: Masami Hiramatsu To: SeongJae Park Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf probe: Fix examples section of documentation Message-Id: <20170509001957.9e6458593fc1b8e9b344761d@kernel.org> In-Reply-To: <20170507103642.30560-1-sj38.park@gmail.com> References: <20170507103642.30560-1-sj38.park@gmail.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 7 May 2017 19:36:42 +0900 SeongJae Park wrote: > An example in perf-probe documentation for pattern of function name > based probe addition is not providing example command for the case. > This commit fixes the example to give appropriate example command. > > Signed-off-by: SeongJae Park Good catch! Acked-by: Masami Hiramatsu Thank you! > --- > tools/perf/Documentation/perf-probe.txt | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/Documentation/perf-probe.txt b/tools/perf/Documentation/perf-probe.txt > index e6c9902c6d82..165c2b1d4317 100644 > --- a/tools/perf/Documentation/perf-probe.txt > +++ b/tools/perf/Documentation/perf-probe.txt > @@ -240,9 +240,13 @@ Add a probe on schedule() function 12th line with recording cpu local variable: > or > ./perf probe --add='schedule:12 cpu' > > - this will add one or more probes which has the name start with "schedule". > +Add one or more probes which has the name start with "schedule". > > - Add probes on lines in schedule() function which calls update_rq_clock(). > + ./perf probe schedule* > + or > + ./perf probe --add='schedule*' > + > +Add probes on lines in schedule() function which calls update_rq_clock(). > > ./perf probe 'schedule;update_rq_clock*' > or > -- > 2.12.0 > -- Masami Hiramatsu