From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753765AbdEICVG (ORCPT ); Mon, 8 May 2017 22:21:06 -0400 Received: from sauhun.de ([88.99.104.3]:58176 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbdEICVE (ORCPT ); Mon, 8 May 2017 22:21:04 -0400 Date: Tue, 9 May 2017 04:21:01 +0200 From: Wolfram Sang To: Brendan Higgins Cc: Rob Herring , Mark Rutland , Thomas Gleixner , Jason Cooper , Marc Zyngier , Joel Stanley , Vladimir Zapolskiy , Kachalov Anton , =?utf-8?Q?C=C3=A9dric?= Le Goater , Benjamin Herrenschmidt , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List , OpenBMC Maillist , Ryan Chen Subject: Re: [PATCH v7 4/5] i2c: aspeed: added driver for Aspeed I2C Message-ID: <20170509022101.GA2562@tetsubishi> References: <20170424181818.2754-1-brendanhiggins@google.com> <20170424181818.2754-5-brendanhiggins@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6TrnltStXW4iwmi0" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6TrnltStXW4iwmi0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > + /* TODO: provide device tree option for multi-master mod= e. > > */ >=20 >=20 > I am curious what everyone thinks about this. It seemed that, earlier on, > people did not like me disabling multi-master mode, but I think that it > would make bus recovery not work as well. Given that, I think it makes the > most sense to provide a device tree option either to enable multi-master > support or disable it. Thoughts? Check Documentation/devicetree/bindings/i2c/i2c.txt, there is a "multi-master" property already which I think you could use here. --6TrnltStXW4iwmi0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJZESeMAAoJEBQN5MwUoCm2YSQP/2gqSPIVc08y4YZYIB6b92J+ gKNpDJI9ZDceKPtUr6TGzpdc5Tlb4KZBjHMLhD5pdKYG2ERs1NY9Oi8j4BfxR5kL RhODk3Mp2IZrZhv4X2gU4ZLv0SzB46t0dDO0TT2WBHsDJOessbgIK/UZX2KoY342 0bKLhOuZS+USKd5xYYerL7CLi0LaKo1MM/+V2Kx8xQhdXSFGj5Qd9ijX3f79pgeL JjdLoCdvZVmax6kvV3RsHCH3i4rW9PZDgSuUEbFX9CfK2yNKDFgJXTElliycfl5z GPL36el1tJ+AZZWib72+ZwgzXmakA6l8Sj7s8hpJZC+nyRKxb8ediUfNZm2k5aQR 7KQBJoPaexLDKS0jv6wPf2RAWJkjAdz6/wiEGjia0mXlGFKHvattDy+23hVOR9fb 0wGuq/YvamSqNZif7pgOkMyQThCORffDM+6OBHFZYI5N1dhkHehv7bbgFfjAcg7Q VpFsy1pOezSBT5Y049Bar2LlRqOrsVRdOoBO41KY8MV3ipBUG5ONyjpVAiESmSTt NMxK07xkK0TqdxVwLO2as2k5hH9o0EGVw+R1MbgUHsaRGcnXT8Wwz39VzpZGLSPV m8Z1ZGsljFiFqkZS/wYN9etWrRLEhe/z9WgJXfOFVOoiQSxyUp/WAd9i+uCSLO9J hqZjimFyVoZ8KzYBAmu4 =3pWS -----END PGP SIGNATURE----- --6TrnltStXW4iwmi0--